From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public•gmane.org>
To: Matthias Schiffer
<mschiffer-Nyw9WiXk/RKXhJHkyCwd5uTW4wlIGRCZ@public•gmane.org>,
Jiri Benc <jbenc-H+wXaHxf7aLQT0dZR+AlfA@public•gmane.org>
Cc: dev-yBygre7rU0TnMu66kgdUjQ@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
roopa-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public•gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
aduyck-nYU0QVwCCFFWk0Htik3J/w@public•gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org
Subject: Re: [PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration
Date: Fri, 23 Jun 2017 15:31:08 +0200 [thread overview]
Message-ID: <1498224668.2595.5.camel@sipsolutions.net> (raw)
In-Reply-To: <a250dc2b-1249-2cfe-6f39-06b7f0874f59-Nyw9WiXk/RKXhJHkyCwd5uTW4wlIGRCZ@public.gmane.org>
On Fri, 2017-06-23 at 14:02 +0200, Matthias Schiffer wrote:
>
> It seems though that rtnl_link_ops.newlink/changelink don't allow
> passing the extack yet... how do we proceed here? Treewide change
> (maybe by someone who knows their Coccinelle-fu?), or would the
> introduction of new versions of the newlink and changelink fields be
> more acceptable, so drivers can be moved to the new API one by one?
I think treewide change is easy enough, this seems to work:
@ops1@
identifier newfn, ops;
@@
static struct rtnl_link_ops ops = {
.newlink = newfn,
...
};
@@
identifier ops1.newfn;
identifier src_net, dev, tb, data;
@@
-int newfn(struct net *src_net, struct net_device *dev,
- struct nlattr *tb[], struct nlattr *data[])
+int newfn(struct net *src_net, struct net_device *dev,
+ struct nlattr *tb[], struct nlattr *data[],
+ struct netlink_ext_ack *extack)
{...}
@ops2@
identifier chfn, ops;
@@
static struct rtnl_link_ops ops = {
.changelink = chfn,
...
};
@@
identifier ops2.chfn;
identifier dev, tb, data;
@@
-int chfn(struct net_device *dev,
- struct nlattr *tb[], struct nlattr *data[])
+int chfn(struct net_device *dev,
+ struct nlattr *tb[], struct nlattr *data[],
+ struct netlink_ext_ack *extack)
{...}
I guess if there are any stragglers you'd find them by compile-testing
:)
johannes
_______________________________________________
dev mailing list
dev@openvswitch•org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
next prev parent reply other threads:[~2017-06-23 13:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 8:03 [PATCH net-next v3 0/6] vxlan: cleanup and IPv6 link-local support Matthias Schiffer
[not found] ` <cover.1497825555.git.mschiffer-Nyw9WiXk/RKXhJHkyCwd5uTW4wlIGRCZ@public.gmane.org>
2017-06-19 8:03 ` [PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration Matthias Schiffer
[not found] ` <6e2c8bb77be42834f1da5a3ca79f5e455574a136.1497825555.git.mschiffer-Nyw9WiXk/RKXhJHkyCwd5uTW4wlIGRCZ@public.gmane.org>
2017-06-23 8:52 ` Jiri Benc
2017-06-23 10:13 ` Matthias Schiffer
[not found] ` <113c3fe1-f490-d92d-2b4a-69b7115d8115-Nyw9WiXk/RKXhJHkyCwd5uTW4wlIGRCZ@public.gmane.org>
2017-06-23 10:23 ` Johannes Berg
[not found] ` <1498213402.2595.3.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2017-06-23 12:02 ` Matthias Schiffer
[not found] ` <a250dc2b-1249-2cfe-6f39-06b7f0874f59-Nyw9WiXk/RKXhJHkyCwd5uTW4wlIGRCZ@public.gmane.org>
2017-06-23 13:31 ` Johannes Berg [this message]
2017-06-19 8:03 ` [PATCH net-next v3 2/6] vxlan: get rid of redundant vxlan_dev.flags Matthias Schiffer
2017-06-19 8:03 ` [PATCH net-next v3 3/6] vxlan: improve validation of address family configuration Matthias Schiffer
2017-06-19 8:03 ` [PATCH net-next v3 4/6] vxlan: check valid combinations of address scopes Matthias Schiffer
2017-06-19 8:03 ` [PATCH net-next v3 5/6] vxlan: fix snooping for link-local IPv6 addresses Matthias Schiffer
2017-06-19 8:04 ` [PATCH net-next v3 6/6] vxlan: allow multiple VXLANs with same VNI for IPv6 link-local addresses Matthias Schiffer
2017-06-20 17:37 ` [PATCH net-next v3 0/6] vxlan: cleanup and IPv6 link-local support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498224668.2595.5.camel@sipsolutions.net \
--to=johannes-cdvu00un1vgdhxzaddlk8q@public$(echo .)gmane.org \
--cc=aduyck-nYU0QVwCCFFWk0Htik3J/w@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=dev-yBygre7rU0TnMu66kgdUjQ@public$(echo .)gmane.org \
--cc=jbenc-H+wXaHxf7aLQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=mschiffer-Nyw9WiXk/RKXhJHkyCwd5uTW4wlIGRCZ@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=roopa-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox