Subject: Re: [PATCH RESEND net-next v3 0/2] bonding: Fix some issues for fail_over_mac

From: Jay Vosburgh <[email-masked]>
Date: Tue, 04 Feb 2014 12:00:31 -0800

Ding Tianhong <[email-masked]> wrote:

>The parameter fail_over_mac only affect active-backup mode, if it was
>set to active or follow and works with other modes, just like RR or XOR
>mode, the bonding could not set all slaves to the master's address, it
>will cause the slave could not work well with master.
>
>v1->v2: According Jay's suggestion, that we should permit setting an option
>	at any time, but only have it take effect in active-backup mode, so
>	I add mode checking together with fail_over_mac during enslavement and
>	rebuild the patches.
>
>v2->v3: The correct way to fix the problem is that we should not add restrictions when
>    	setting options, just need to modify the bond enslave and removal processing
>    	to check the mode in addition to fail_over_mac when setting a slave's MAC during
>    	enslavement. The change active slave processing already only calls the fail_over_mac
>    	function when in active-backup mode.
>
>	Remove the cleanup patch because the net-next is frozen now.
>
>Regards
>Ding

	Both patches look good to me.

Signed-off-by: Jay Vosburgh <[email-masked]>

	-J
	
---
	-Jay Vosburgh, IBM Linux Technology Center, [email-masked]