public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Paolo Abeni <pabeni@redhat•com>
To: Paul Moore <paul@paul-moore•com>
Cc: netdev@vger•kernel.org, selinux@tycho•nsa.gov
Subject: Re: SELinux/IP_PASSSEC regression in 4.13-rcX
Date: Tue, 25 Jul 2017 11:59:38 +0200	[thread overview]
Message-ID: <1500976778.2929.5.camel@redhat.com> (raw)
In-Reply-To: <CAHC9VhQC1Bpm9VdE2sBC4VLmnzu_B7kLEkgBtnDKvwKf5w1HyA@mail.gmail.com>

On Mon, 2017-07-24 at 22:00 -0400, Paul Moore wrote:
> > I'm happy to test this, but if you are curious, you can find the
> > selinux-testsuite at the link below; the "inet_socket" tests are the
> > ones relevant to this problem.
> > 
> > * https://github.com/SELinuxProject/selinux-testsuite

Thanks, I'll have a look.

> > However, I believe there is a problem with this patch, see below.

[...]

> > > -#if BITS_PER_LONG == 64
> > > +#define UDP_SKB_IS_STATELESS 0x80000000
> > > +
> > >  static void udp_set_dev_scratch(struct sk_buff *skb)
> > >  {
> > > -       struct udp_dev_scratch *scratch;
> > > +       struct udp_dev_scratch *scratch = udp_skb_scratch(skb);
> > > 
> > >         BUILD_BUG_ON(sizeof(struct udp_dev_scratch) > sizeof(long));
> > 
> > The BUILD_BUG_ON() assertion no longer appears to be correct with this patch.
> 
> Nevermind, I just took a closer look at this and realized I made a
> mistake when applying your patch (had to apply manually for some
> reason).  I'm building a test kernel now.

Yup, I compile-tested the code, plus some basic sanity checks, so the
build breakage felt unexpected.

Thanks for testing,

Paolo

next prev parent reply	other threads:[~2017-07-25  9:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-21 22:19 SELinux/IP_PASSSEC regression in 4.13-rcX Paul Moore
2017-07-24 12:25 ` Paolo Abeni
2017-07-24 14:42   ` Paul Moore
2017-07-24 16:09     ` Paolo Abeni
2017-07-24 19:00       ` Paul Moore
2017-07-25  2:00         ` Paul Moore
2017-07-25  9:59           ` Paolo Abeni [this message]
2017-07-25 14:45             ` Paul Moore
2017-07-25 15:36               ` Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500976778.2929.5.camel@redhat.com \
    --to=pabeni@redhat$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=paul@paul-moore$(echo .)com \
    --cc=selinux@tycho$(echo .)nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox