From: "Coelho, Luciano" <luciano.coelho@intel•com>
To: "kvalo@codeaurora•org" <kvalo@codeaurora•org>,
"mcgrof@kernel•org" <mcgrof@kernel•org>
Cc: "pieter-paul.giesberts@broadcom•com"
<pieter-paul.giesberts@broadcom•com>,
"bjorn.andersson@linaro•org" <bjorn.andersson@linaro•org>,
"arend.vanspriel@broadcom•com" <arend.vanspriel@broadcom•com>,
"hante.meuleman@broadcom•com" <hante.meuleman@broadcom•com>,
"gregkh@linuxfoundation•org" <gregkh@linuxfoundation•org>,
"keescook@chromium•org" <keescook@chromium•org>,
"linux-wireless@vger•kernel.org" <linux-wireless@vger•kernel.org>,
"alan@linux•intel.com" <alan@linux•intel.com>,
"moritz.fischer@ettus•com" <moritz.fischer@ettus•com>,
"pjones@redhat•com" <pjones@redhat•com>,
"wagi@monom•org" <wagi@monom•org>,
"pmladek@suse•com" <pmladek@suse•com>,
"atull@kernel•org" <atull@kernel•org>,
"yi1.li@linux•intel.com" <yi1.li@linux•intel.com>,
"wright.feng@cypress•com" <wright.f
Subject: Re: [PATCH V5 1/2] firmware: add more flexible request_firmware_async function
Date: Thu, 3 Aug 2017 05:55:18 +0000 [thread overview]
Message-ID: <1501739717.15969.26.camel@intel.com> (raw)
In-Reply-To: <878tj1ql6z.fsf@kamboji.qca.qualcomm.com>
On Thu, 2017-08-03 at 08:23 +0300, Kalle Valo wrote:
> "Luis R. Rodriguez" <mcgrof@kernel•org> writes:
>
> > > +int request_firmware_nowait(struct module *module, bool uevent,
> > > + const char *name, struct device *device, gfp_t gfp,
> > > + void *context,
> > > + void (*cont)(const struct firmware *fw, void *context))
> > > +{
> > > + unsigned int opt_flags = FW_OPT_FALLBACK |
> > > + (uevent ? FW_OPT_UEVENT : FW_OPT_USERHELPER);
> > > +
> > > + return __request_firmware_nowait(module, opt_flags, name, device, gfp,
> > > + context, cont);
> > > +}
> > > EXPORT_SYMBOL(request_firmware_nowait);
> > >
> > > +int __request_firmware_async(struct module *module, const char *name,
> > > + struct firmware_opts *fw_opts, struct device *dev,
> > > + void *context,
> > > + void (*cont)(const struct firmware *fw, void *context))
> > > +{
> > > + unsigned int opt_flags = FW_OPT_UEVENT;
> >
> > This exposes a long issue. Think -- why do we want this enabled by default? Its
> > actually because even though the fallback stuff is optional and can be, the uevent
> > internal flag *also* provides caching support as a side consequence only. We
> > don't want to add a new API without first cleaning up that mess.
> >
> > This is a slipery slope and best to clean that up before adding any new API.
> >
> > That and also Greg recently stated he would like to see at least 3 users of
> > a feature before adding it. Although I think that's pretty arbitrary, and
> > considering that request_firmware_into_buf() only has *one* user -- its what
> > he wishes.
>
> ath10k at least needs a way to silence the warning for missing firmware
> and I think iwlwifi also.
Yes, iwlwifi needs to silence the warning. It the feature (only one,
really) that I've been waiting for.
--
Luca.
next prev parent reply other threads:[~2017-08-03 5:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 15:09 [PATCH V5 1/2] firmware: add more flexible request_firmware_async function Rafał Miłecki
2017-07-31 15:09 ` [PATCH V5 2/2] brcmfmac: don't warn user about NVRAM if fallback to the platform one succeeds Rafał Miłecki
2017-08-01 21:20 ` Arend van Spriel
2017-07-31 23:01 ` [PATCH V5 1/2] firmware: add more flexible request_firmware_async function kbuild test robot
2017-08-02 21:30 ` Luis R. Rodriguez
2017-08-03 5:23 ` Kalle Valo
2017-08-03 5:55 ` Coelho, Luciano [this message]
2017-08-03 16:31 ` Luis R. Rodriguez
2017-08-10 17:07 ` Luis R. Rodriguez
2017-08-10 17:05 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501739717.15969.26.camel@intel.com \
--to=luciano.coelho@intel$(echo .)com \
--cc=alan@linux$(echo .)intel.com \
--cc=arend.vanspriel@broadcom$(echo .)com \
--cc=atull@kernel$(echo .)org \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hante.meuleman@broadcom$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=kvalo@codeaurora$(echo .)org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=mcgrof@kernel$(echo .)org \
--cc=moritz.fischer@ettus$(echo .)com \
--cc=pieter-paul.giesberts@broadcom$(echo .)com \
--cc=pjones@redhat$(echo .)com \
--cc=pmladek@suse$(echo .)com \
--cc=wagi@monom$(echo .)org \
--cc=yi1.li@linux$(echo .)intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox