From: Joe Perches <joe@perches•com>
To: Nathan Fontenot <nfont@linux•vnet.ibm.com>, netdev@vger•kernel.org
Cc: jallen@linux•vnet.ibm.com, tlfalcon@linux•vnet.ibm.com
Subject: Re: [PATCH net-next] ibmvnic: Add netdev_dbg output for debugging
Date: Mon, 07 Aug 2017 08:29:55 -0700 [thread overview]
Message-ID: <1502119795.2219.21.camel@perches.com> (raw)
In-Reply-To: <20170807190258.13228.24698.stgit@ltcalpine2-lp23.aus.stglabs.ibm.com>
On Mon, 2017-08-07 at 15:02 -0400, Nathan Fontenot wrote:
> To ease debugging of the ibmvnic driver add a series of netdev_dbg()
> statements to track driver status, especially during initialization,
> removal, and resetting of the driver.
For some of the function entry logging, it seems
better to use ftrace instead.
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
[]
> @@ -389,6 +389,8 @@ static int init_stats_token(struct ibmvnic_adapter *adapter)
> struct device *dev = &adapter->vdev->dev;
> dma_addr_t stok;
>
> + netdev_dbg(adapter->netdev, "Initializing stats token\n");
here and subsequent.
next prev parent reply other threads:[~2017-08-07 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 19:02 [PATCH net-next] ibmvnic: Add netdev_dbg output for debugging Nathan Fontenot
2017-08-07 15:29 ` Joe Perches [this message]
2017-08-08 13:39 ` Nathan Fontenot
2017-08-08 16:27 ` Stephen Hemminger
2017-08-08 17:27 ` Nathan Fontenot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502119795.2219.21.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=jallen@linux$(echo .)vnet.ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nfont@linux$(echo .)vnet.ibm.com \
--cc=tlfalcon@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox