From: Joe Perches <joe@perches•com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor•com>,
Jeff Kirsher <jeffrey.t.kirsher@intel•com>,
davem@davemloft•net
Cc: netdev@vger•kernel.org, nhorman@redhat•com, sassmann@redhat•com,
jogreene@redhat•com
Subject: Re: [net-next 03/12] e1000e: add check on e1e_wphy() return value
Date: Thu, 10 Aug 2017 19:53:40 -0700 [thread overview]
Message-ID: <1502420020.3099.1.camel@perches.com> (raw)
In-Reply-To: <c36867bd-fcb1-40b6-4f6e-b3ad2e6360dc@embeddedor.com>
On Thu, 2017-08-10 at 21:47 -0500, Gustavo A. R. Silva wrote:
> Hello everybody,
>
> I'm a little confused. Is this patch causing any trouble?
Not to me. I no longer have an e1000e.
Given the commit message, this just seemed to be a patch
that _might_ cause an issue if this code patch is actually
untested.
Compilation wise, it's obviously fine.
> On 08/10/2017 12:56 PM, Joe Perches wrote:
> > On Wed, 2017-08-09 at 14:47 -0700, Jeff Kirsher wrote:
> > > From: Gustavo A R Silva <garsilva@embeddedor•com>
> > >
> > > Check return value from call to e1e_wphy(). This value is being
> > > checked during previous calls to function e1e_wphy() and it seems
> > > a check was missing here.
> >
> > The use of "it seems" here is less than compelling.
> >
>
> This is one of the first patches I sent. Maybe I should have added a
> note saying that this patch needed some testing, as I don't have the
> hardware to test it.
>
> > Perhaps the write of 0x3140 to MII_BMCR takes too long for
> > the return value used.
> >
> > Many other uses of e1e_wphy.*MII_BMCR are also not checked.
> >
> > For instance: the e100e/ethtool uses.
> >
> > > diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c
> >
> > []
> > > @@ -2437,6 +2437,8 @@ static s32 e1000_hv_phy_workarounds_ich8lan(struct e1000_hw *hw)
> > > if (hw->phy.revision < 2) {
> > > e1000e_phy_sw_reset(hw);
> > > ret_val = e1e_wphy(hw, MII_BMCR, 0x3140);
> > > + if (ret_val)
> > > + return ret_val;
> > > }
> > > }
> > >
>
> Thanks
next prev parent reply other threads:[~2017-08-11 2:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 21:47 [net-next 00/12][pull request] 1GbE Intel Wired LAN Driver Updates 2017-08-08 Jeff Kirsher
2017-08-09 21:47 ` [net-next 01/12] igb: Fix error of RX network flow classification Jeff Kirsher
2017-08-09 21:47 ` [net-next 02/12] igb: protect TX timestamping from API misuse Jeff Kirsher
2017-08-09 21:47 ` [net-next 03/12] e1000e: add check on e1e_wphy() return value Jeff Kirsher
2017-08-10 17:56 ` Joe Perches
2017-08-11 2:47 ` Gustavo A. R. Silva
2017-08-11 2:53 ` Joe Perches [this message]
2017-08-11 3:54 ` Jeff Kirsher
2017-08-09 21:47 ` [net-next 04/12] igb: Remove incorrect "unexpected SYS WRAP" log message Jeff Kirsher
2017-08-09 21:47 ` [net-next 05/12] igb: add argument names to mailbox op function declarations Jeff Kirsher
2017-08-09 21:47 ` [net-next 06/12] igb: expose mailbox unlock method Jeff Kirsher
2017-08-09 21:47 ` [net-next 07/12] igb: do not drop PF mailbox lock after read of VF message Jeff Kirsher
2017-08-09 21:47 ` [net-next 08/12] e1000e: Initial Support for IceLake Jeff Kirsher
2017-08-09 21:47 ` [net-next 09/12] igbvf: add lock around mailbox ops Jeff Kirsher
2017-08-09 21:47 ` [net-next 10/12] igbvf: after mailbox write, wait for reply Jeff Kirsher
2017-08-09 21:47 ` [net-next 11/12] igbvf: convert msleep to mdelay in atomic context Jeff Kirsher
2017-08-14 10:17 ` David Laight
2017-08-15 19:32 ` Greg Edwards
2017-08-16 10:58 ` David Laight
2017-08-09 21:47 ` [net-next 12/12] igb: support BCM54616 PHY Jeff Kirsher
2017-08-09 23:49 ` [net-next 00/12][pull request] 1GbE Intel Wired LAN Driver Updates 2017-08-08 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502420020.3099.1.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=garsilva@embeddedor$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jogreene@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@redhat$(echo .)com \
--cc=sassmann@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox