From: Jeff Kirsher <jeffrey.t.kirsher@intel•com>
To: Stefano Brivio <sbrivio@redhat•com>,
netdev@vger•kernel.org, intel-wired-lan@lists•osuosl.org
Cc: "David S . Miller" <davem@davemloft•net>,
Anjali Singhai Jain <anjali.singhai@intel•com>
Subject: Re: [PATCH net 1/2] i40e: Fix comment about locking for __i40e_read_nvm_word()
Date: Wed, 06 Sep 2017 18:16:11 -0700 [thread overview]
Message-ID: <1504746971.3922.83.camel@intel.com> (raw)
In-Reply-To: <4d27bbb33031ac1489fe6d969edd74d44155136c.1504684488.git.sbrivio@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
On Wed, 2017-09-06 at 10:11 +0200, Stefano Brivio wrote:
> Caller needs to acquire the lock. Called functions will not.
>
> Fixes: 09f79fd49d94 ("i40e: avoid NVM acquire deadlock during NVM
> update")
> Signed-off-by: Stefano Brivio <sbrivio@redhat•com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_nvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Yes, this fixes the function header comment, not sure if it requires
the "Fixes:" tag. If that were the case, wonder why all the other code
comment changes do not have this. :-) I do agree it reads better with
this change, so I do not have an issue queue this up for Dave's net
tree.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-09-07 1:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 8:11 [PATCH net 0/2] i40e: Two trivial fixes for 09f79fd49d94 Stefano Brivio
2017-09-06 8:11 ` [PATCH net 1/2] i40e: Fix comment about locking for __i40e_read_nvm_word() Stefano Brivio
2017-09-07 1:16 ` Jeff Kirsher [this message]
2017-09-06 8:11 ` [PATCH net 2/2] i40e: Avoid some useless variables and initializers in nvm functions Stefano Brivio
2017-09-07 1:13 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504746971.3922.83.camel@intel.com \
--to=jeffrey.t.kirsher@intel$(echo .)com \
--cc=anjali.singhai@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sbrivio@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox