From: Joe Perches <joe@perches•com>
To: Alexey Dobriyan <adobriyan@gmail•com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH] net: Convert int functions to bool
Date: Wed, 13 Sep 2017 15:55:50 -0700 [thread overview]
Message-ID: <1505343350.8969.22.camel@perches.com> (raw)
In-Reply-To: <20170913223158.GA7860@avx2>
On Thu, 2017-09-14 at 01:31 +0300, Alexey Dobriyan wrote:
> > Global function ipv6_rcv_saddr_equal and static functions
> > ipv6_rcv_saddr_equal and ipv4_rcv_saddr_equal currently return int.
> >
> > bool is slightly more descriptive for these functions so change
> > their return type from int to bool.
>
> From code generation POV "int" is better for non-inlined functions
> especially on non-x86.
I don't agree with you here. For instance:
$ size net/ipv4/*.o*
text data bss dec hex filename
9832 26 0 9858 2682 net/ipv4/inet_connection_sock.o.arm.defconfig.new
9860 26 0 9886 269e net/ipv4/inet_connection_sock.o.arm.defconfig.old
next prev parent reply other threads:[~2017-09-13 22:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 22:31 [PATCH] net: Convert int functions to bool Alexey Dobriyan
2017-09-13 22:55 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-09-13 20:58 Joe Perches
2017-09-18 18:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505343350.8969.22.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=adobriyan@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox