public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Paolo Abeni <pabeni@redhat•com>
To: Jiri Pirko <jiri@resnulli•us>
Cc: Or Gerlitz <gerlitz.or@gmail•com>, Jiri Benc <jbenc@redhat•com>,
	Simon Horman <simon.horman@netronome•com>,
	David Miller <davem@davemloft•net>,
	Jakub Kicinski <jakub.kicinski@netronome•com>,
	Linux Netdev List <netdev@vger•kernel.org>,
	oss-drivers@netronome•com,
	John Hurley <john.hurley@netronome•com>,
	Paul Blakey <paulb@mellanox•com>, Jiri Pirko <jiri@mellanox•com>,
	Roi Dayan <roid@mellanox•com>
Subject: tc H/W offload issue with vxlan tunnels [was: nfp: flower vxlan tunnel offload]
Date: Wed, 27 Sep 2017 10:29:35 +0200	[thread overview]
Message-ID: <1506500975.2867.19.camel@redhat.com> (raw)

Hi,

Moving to a separate theread, since I think this is more related to the
flower core infrastructure than to the netrome patches.

On Wed, 2017-09-27 at 09:40 +0200, Jiri Pirko wrote:
> This kind of hooks are giving me nightmares. The code is screwed up as
> it is already. I'm currently working on conversion to callbacks. This
> part is handled in:
> https://github.com/jpirko/linux_mlxsw/commits/jiri_devel_egdevcb

Thanks for the pointer.

I skimmed quickly on the code and indeed it cleans this area a lot.
If I read it correctly the ('good') command:

tc filter add dev vxlan0 protocol ip parent ffff: flower enc_key_id 102 
   enc_dst_port 4789 src_ip 3.4.5.6 skip_sw action [...]

will generate a call to:

mlx5e_setup_tc(eth0, TC_SETUP_CLSFLOWER, &cls_flower) via:

fl_hw_replace_filter() ->
  tc_setup_cb_call() -> 
    tc_exts_setup_cb_egdev_call() ->
      tc_setup_cb_egdev_call() ->
        tcf_action_egdev_cb_call() ->
          mlx5e_rep_setup_tc_cb()

and the 'bad' command:

tc filter add dev eth0 protocol ip parent ffff: flower enc_key_id 102 \
   enc_dst_port 4789 src_ip 3.4.5.6 skip_sw action [...]

will also call:

mlx5e_setup_tc(eth0, TC_SETUP_CLSFLOWER, &cls_flower) via:

fl_hw_replace_filter() ->
  ndo_setup_tc()

So it looks like the H/W offload hook will still be called with the
same arguments in both case, and 'bad' rule will still be pushed to the
H/W as the driver itself has no way to distinct between the two
scenarios.

[ Note: I referred to the mlx hook just for convenience, should be the
same with any driver implementing the same APIs ]

Am I missing something?

Thanks,

Paolo

next             reply	other threads:[~2017-09-27  8:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-27  8:29 Paolo Abeni [this message]
2017-09-27  9:17 ` tc H/W offload issue with vxlan tunnels [was: nfp: flower vxlan tunnel offload] Jiri Pirko
2017-09-27  9:46   ` Paolo Abeni
2017-09-27 11:11     ` Jiri Pirko
2017-09-27 12:31       ` Paolo Abeni
2017-09-27 12:55         ` Jiri Pirko
2017-09-27 15:27           ` Jiri Benc
2017-09-27 15:35             ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1506500975.2867.19.camel@redhat.com \
    --to=pabeni@redhat$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=gerlitz.or@gmail$(echo .)com \
    --cc=jakub.kicinski@netronome$(echo .)com \
    --cc=jbenc@redhat$(echo .)com \
    --cc=jiri@mellanox$(echo .)com \
    --cc=jiri@resnulli$(echo .)us \
    --cc=john.hurley@netronome$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=oss-drivers@netronome$(echo .)com \
    --cc=paulb@mellanox$(echo .)com \
    --cc=roid@mellanox$(echo .)com \
    --cc=simon.horman@netronome$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox