From: Joe Perches <joe@perches•com>
To: David Laight <David.Laight@ACULAB•COM>,
"Gustavo A. R. Silva" <garsilva@embeddedor•com>,
Jes Sorensen <Jes.Sorensen@gmail•com>,
Kalle Valo <kvalo@codeaurora•org>
Cc: "linux-wireless@vger•kernel.org" <linux-wireless@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
Arnaldo Carvalho de Melo <acme@infradead•org>
Subject: Re: [PATCH] rtl8xxxu: mark expected switch fall-throughs
Date: Wed, 11 Oct 2017 10:47:13 -0700 [thread overview]
Message-ID: <1507744033.3552.55.camel@perches.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DD009123C@AcuExch.aculab.com>
On Wed, 2017-10-11 at 12:54 +0000, David Laight wrote:
> From: Joe Perches
> > Sent: 11 October 2017 11:21
> > On Tue, 2017-10-10 at 14:30 -0500, Gustavo A. R. Silva wrote:
> > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > > where we are expecting to fall through.
> >
> > perhaps use Arnaldo's idea:
> >
> > https://lkml.org/lkml/2017/2/9/845
> > https://lkml.org/lkml/2017/2/10/485
>
> gah, that is even uglier and requires a chase through
> headers to find out what it means.
Sure, if you think __fallthrough; isn't self-documenting.
case foo;
bar;
__fallthrough;
case baz;
etc...
prev parent reply other threads:[~2017-10-11 17:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 19:30 [PATCH] rtl8xxxu: mark expected switch fall-throughs Gustavo A. R. Silva
2017-10-10 19:35 ` Jes Sorensen
[not found] ` <5f5f0f54-d901-90be-9025-0a1c4b909368-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-10 19:55 ` Florian Fainelli
2017-10-11 8:41 ` Kalle Valo
2017-10-11 13:34 ` Jes Sorensen
2017-10-11 14:32 ` Gustavo A. R. Silva
2017-10-11 17:00 ` Kees Cook
[not found] ` <eb89f2ad-f2d5-b97f-c224-daf3953d912c-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-12 4:32 ` Kalle Valo
2017-10-11 10:20 ` Joe Perches
2017-10-11 12:54 ` David Laight
2017-10-11 17:47 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507744033.3552.55.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=David.Laight@ACULAB$(echo .)COM \
--cc=Jes.Sorensen@gmail$(echo .)com \
--cc=acme@infradead$(echo .)org \
--cc=garsilva@embeddedor$(echo .)com \
--cc=kvalo@codeaurora$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox