From: Franchoze Eric <franchoze@yandex•ru>
To: Jarek Poplawski <jarkao2@gmail•com>
Cc: David Miller <davem@davemloft•net>,
shemminger@vyatta•com, netdev@vger•kernel.org
Subject: Re: Re: [PATCH] sfq: add dummy bind/unbind handles
Date: Mon, 09 Aug 2010 19:01:17 +0400 [thread overview]
Message-ID: <151621281366078@web89.yandex.ru> (raw)
In-Reply-To: <4C5E570E.6020908@gmail.com>
08.08.10, 11:04, "Jarek Poplawski" <jarkao2@gmail•com>:
> David Miller wrote, On 08.08.2010 07:45:
>
> > From: Jarek Poplawski
> > Date: Sat, 07 Aug 2010 01:17:07 +0200
> >
> >> Stephen Hemminger wrote, On 07.08.2010 00:23:
> >>
> >>> Applying a filter to an SFQ qdisc would cause null dereference
> >>> in tcf_bind_filter because although SFQ is classful it didn't
> >>> have all the necessary equipment.
> >>>
> >>> Better alternative to changing tcf_bind API is to just fix
> >>> SFQ. This should go to net-2.6 and stable.
> >>>
> >>
> >> Hmm... FYI, actually I've sent already a similar patch to the
> >> original bug report thread (except .unbind_tcf method which
> >> doesn't matter for fixing this bug, so should be rather
> >> implemented in a separate patch, if needed at all in this
> >> case).
> >
> > Agreed, I can't see a way that unbind can ever be invoked
> > if the bind call always returns zero.
>
> To tell the truth, I think unbind should be implemented anyway,
> just for consistency, safety, and easier verification. But, looking
> at a similar case of .get and .put in the same driver, Patrick
> seemed to do it purposely, so I expected some discussion about the
> rules yet, and made it minimal to ease merging to older kernels.
>
> Thanks,
> Jarek P.
>
>
As for me it's better to add unbind now that get unexpected null derefance in future with API changing...
next prev parent reply other threads:[~2010-08-09 15:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100806193548.007978639@vyatta.com>
2010-08-06 19:35 ` [PATCH 1/9] net classifier: dont allow filters on semi-classful qdisc Stephen Hemminger
2010-08-06 21:24 ` Jarek Poplawski
2010-08-06 21:58 ` Stephen Hemminger
2010-08-06 22:23 ` [PATCH] sfq: add dummy bind/unbind handles Stephen Hemminger
2010-08-06 23:17 ` Jarek Poplawski
2010-08-08 5:45 ` David Miller
2010-08-08 7:04 ` Jarek Poplawski
2010-08-09 15:01 ` Franchoze Eric [this message]
2010-08-06 22:26 ` [PATCH 1/9] net classifier: dont allow filters on semi-classful qdisc Jarek Poplawski
2010-08-08 5:59 ` David Miller
2010-08-06 19:35 ` [PATCH 2/9] net classifier: deinline bind/unbind functions Stephen Hemminger
2010-08-06 19:35 ` [PATCH 3/9] u32 classifier: fix sparse warnings Stephen Hemminger
2010-08-06 19:35 ` [PATCH 4/9] netem: add locking around changes Stephen Hemminger
2010-08-06 19:35 ` [PATCH 5/9] netem: cleanup dump code Stephen Hemminger
2010-08-06 19:35 ` [PATCH 6/9] netem: distribution table changes Stephen Hemminger
2010-08-06 19:35 ` [PATCH 7/9] netem: dump distribution table Stephen Hemminger
2010-08-06 19:35 ` [PATCH 8/9] netem - revised correlated loss generator Stephen Hemminger
2010-08-06 19:35 ` [PATCH 9/9] netem: restore no jitter option Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151621281366078@web89.yandex.ru \
--to=franchoze@yandex$(echo .)ru \
--cc=davem@davemloft$(echo .)net \
--cc=jarkao2@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox