public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail•com>
To: Patrick Talbert <ptalbert@redhat•com>, netdev@vger•kernel.org
Subject: Re: [PATCH net-next] [net] softnet_data: Split time_squeeze counter to provide budget_squeeze
Date: Tue, 23 Jan 2018 09:07:06 -0800	[thread overview]
Message-ID: <1516727226.3715.1.camel@gmail.com> (raw)
In-Reply-To: <1516721834-7740-1-git-send-email-ptalbert@redhat.com>

On Tue, 2018-01-23 at 10:37 -0500, Patrick Talbert wrote:
> Add a 'budget_squeeze' counter to be able to differenciate between a
> NAPI poll ending with outstanding work because of a lack of budget
> (netdev_budget) versus ending because of a lack of time
> (netdev_budget_usecs).
> 
> Signed-off-by: Patrick Talbert <ptalbert@redhat•com>


> --- a/net/core/net-procfs.c
> +++ b/net/core/net-procfs.c
> @@ -160,11 +160,11 @@ static int softnet_seq_show(struct seq_file *seq, void *v)
>  #endif
>  
>  	seq_printf(seq,
> -		   "%08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x\n",
> +		   "%08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x\n",
>  		   sd->processed, sd->dropped, sd->time_squeeze, 0,
>  		   0, 0, 0, 0, /* was fastroute */
>  		   0,	/* was cpu_collision */
> -		   sd->received_rps, flow_limit_count);
> +		   sd->received_rps, flow_limit_count, sd->budget_squeeze);
>  	return 0;
>  }

Please no more updates on /proc files. We want to deprecate them
eventually.

  reply	other threads:[~2018-01-23 17:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-23 15:37 [PATCH net-next] [net] softnet_data: Split time_squeeze counter to provide budget_squeeze Patrick Talbert
2018-01-23 17:07 ` Eric Dumazet [this message]
2018-01-24 13:25   ` Patrick Talbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516727226.3715.1.camel@gmail.com \
    --to=eric.dumazet@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=ptalbert@redhat$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox