From: Luciano Coelho <luciano.coelho@intel•com>
To: Ulf Magnusson <ulfalizer@gmail•com>, linux-kernel@vger•kernel.org
Cc: linux-kbuild@vger•kernel.org, tfiga@chromium•org,
paul.burton@mips•com, m.szyprowski@samsung•com,
egtvedt@samfundet•no, linus.walleij@linaro•org,
vgupta@synopsys•com, mgorman@techsingularity•net, hch@lst•de,
mina86@mina86•com, robh@kernel•org, sboyd@codeaurora•org,
paulus@ozlabs•org, will.deacon@arm•com, tony@atomide•com,
npiggin@gmail•com, yamada.masahiro@socionext•com,
Johannes Berg <johannes.berg@intel•com>,
Emmanuel Grumbach <emmanuel.grumbach@intel•com>,
Intel Linux Wireless <linuxwifi@intel•com>,
Kalle Valo <kvalo@codeaurora•org>,
linux-wireless@vger•kernel.org, netdev@vger•kernel.org
Subject: Re: [PATCH 18/20] iwlwifi: fix malformed CONFIG_IWLWIFI_PCIE_RTPM default
Date: Thu, 15 Feb 2018 09:35:51 +0200 [thread overview]
Message-ID: <1518680151.7832.26.camel@intel.com> (raw)
In-Reply-To: <20180205012146.23981-19-ulfalizer@gmail.com>
On Mon, 2018-02-05 at 02:21 +0100, Ulf Magnusson wrote:
> 'default false' should be 'default n', though they happen to have the
> same effect here, due to undefined symbols ('false' in this case)
> evaluating to n in a tristate sense.
>
> Remove the default instead of changing it. bool and tristate symbols
> implicitly default to n.
>
> Discovered with the
> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_und
> efined.py
> script.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail•com>
> ---
Thanks, Ulf!
This is applied in our internal tree and will eventually reach the
mainline, following our usual upstreaming process.
--
Cheers,
Luca.
prev parent reply other threads:[~2018-02-15 7:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180205012146.23981-1-ulfalizer@gmail.com>
2018-02-05 1:21 ` [PATCH 18/20] iwlwifi: fix malformed CONFIG_IWLWIFI_PCIE_RTPM default Ulf Magnusson
2018-02-15 7:35 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518680151.7832.26.camel@intel.com \
--to=luciano.coelho@intel$(echo .)com \
--cc=egtvedt@samfundet$(echo .)no \
--cc=emmanuel.grumbach@intel$(echo .)com \
--cc=hch@lst$(echo .)de \
--cc=johannes.berg@intel$(echo .)com \
--cc=kvalo@codeaurora$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-kbuild@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linuxwifi@intel$(echo .)com \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=mgorman@techsingularity$(echo .)net \
--cc=mina86@mina86$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=npiggin@gmail$(echo .)com \
--cc=paul.burton@mips$(echo .)com \
--cc=paulus@ozlabs$(echo .)org \
--cc=robh@kernel$(echo .)org \
--cc=sboyd@codeaurora$(echo .)org \
--cc=tfiga@chromium$(echo .)org \
--cc=tony@atomide$(echo .)com \
--cc=ulfalizer@gmail$(echo .)com \
--cc=vgupta@synopsys$(echo .)com \
--cc=will.deacon@arm$(echo .)com \
--cc=yamada.masahiro@socionext$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox