Subject: Re: [PATCH 12/15] ice: Add stats and ethtool support

From: "Venkataramanan, Anirudh" <[email-masked]>
Date: Tue, 13 Mar 2018 20:42:45 +0000

On Sat, 2018-03-10 at 08:42 -0800, Stephen Hemminger wrote:
> On Fri,  9 Mar 2018 09:21:33 -0800
> Anirudh Venkataramanan <[email-masked]> wrote:
> 
> > +	/* VSI stats */
> > +	struct rtnl_link_stats64 net_stats;
> > +	struct rtnl_link_stats64 net_stats_prev;
> > +	struct ice_eth_stats eth_stats;
> > +	struct ice_eth_stats eth_stats_prev;
> 
> You also don't need current and previous as separate copies since
> previous is only
> used while computing the current values.

Thanks for the feedback, Stephen.

eth_stats_prev is used in ice_update_eth_stats when we update
eth_stats.

While looking into this though, I found that net_stats_prev field in
struct ice_vsi (and consequently *prev_ns and *prev_es pointers in
ice_update_vsi_stats) may not be needed. Is this what you meant?

Thanks!
Ani