From: Joe Perches <joe@perches•com>
To: Pkshih <pkshih@realtek•com>,
"huxm@marvell•com" <huxm@marvell•com>,
"gbhat@marvell•com" <gbhat@marvell•com>,
"jussi.kivilinna@iki•fi" <jussi.kivilinna@iki•fi>,
"nishants@marvell•com" <nishants@marvell•com>,
"kvalo@codeaurora•org" <kvalo@codeaurora•org>,
"amitkarwar@gmail•com" <amitkarwar@gmail•com>,
"chunkeey@googlemail•com" <chunkeey@googlemail•com>
Cc: "linux-wireless@vger•kernel.org" <linux-wireless@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"b43-dev@lists•infradead.org" <b43-dev@lists•infradead.org>
Subject: Re: [PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address
Date: Sat, 31 Mar 2018 07:33:28 -0700 [thread overview]
Message-ID: <1522506808.11653.7.camel@perches.com> (raw)
In-Reply-To: <1522504872.1910.17.camel@realtek.com>
On Sat, 2018-03-31 at 14:01 +0000, Pkshih wrote:
> On Sat, 2018-03-31 at 00:05 -0700, Joe Perches wrote:
> > Use the new ether_broadcast_addr global instead to save some object code.
[]
> > diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c
[]
> > @@ -1649,7 +1648,7 @@ static int rtl_op_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
> > memcpy(rtlpriv->sec.key_buf[key_idx],
> > key->key, key->keylen);
> > rtlpriv->sec.key_len[key_idx] = key->keylen;
> > - memcpy(mac_addr, bcast_addr, ETH_ALEN);
> > + memcpy(mac_addr, ether_broadcast_addr, ETH_ALEN);
>
> Use ether_addr_copy(mac_addr, ether_broadcast_addr) ?
This should use eth_broadcast_addr(mac_addr) instead.
There are similar conversion still possible in the tree.
One day.
next prev parent reply other threads:[~2018-03-31 14:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-31 7:05 [PATCH 00/12] Ethernet: Add and use ether_<type>_addr globals Joe Perches
2018-03-31 7:05 ` [PATCH 01/12] ethernet: Add generic ether_<foo>_addr addresses Joe Perches
2018-03-31 7:05 ` [PATCH 02/12] treewide/net: Rename eth_stp_addr to ether_stp_addr Joe Perches
2018-03-31 17:36 ` Andrew Lunn
2018-03-31 18:01 ` Joe Perches
2018-03-31 18:34 ` [PATCH V2] " Joe Perches
2018-04-01 18:07 ` David Miller
2018-04-01 0:18 ` [PATCH 02/12] " kbuild test robot
2018-03-31 7:05 ` [PATCH 03/12] net: mac80211: Use global ether_broadcast_addr Joe Perches
2018-03-31 7:05 ` [PATCH 04/12] bridge: netfilter: Use the new global ether_<foo>_addr arrays Joe Perches
2018-03-31 18:28 ` Pablo Neira Ayuso
2018-03-31 18:40 ` Joe Perches
2018-03-31 7:05 ` [PATCH 05/12] net: atm: Use ether_broadcast_addr Joe Perches
2018-03-31 7:05 ` [PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address Joe Perches
[not found] ` <79196f134a513d50968e8e208a0e56b3c0236ee3.1522479607.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2018-03-31 14:01 ` Pkshih
2018-03-31 14:33 ` Joe Perches [this message]
2018-04-05 12:39 ` Kalle Valo
2018-04-05 12:48 ` Kalle Valo
2018-03-31 7:05 ` [PATCH 07/12] brcmfmac: Convert ALLFFMAC to ether_broadcast_addr Joe Perches
2018-04-05 19:00 ` Arend van Spriel
2018-03-31 7:05 ` [PATCH 08/12] iwlegacy: Remove EXPORT_SYMBOL(il_bcast_addr) and use ether_broadcast_addr Joe Perches
2018-03-31 7:05 ` [PATCH 09/12] iwlwifi: Remove local iwl_bcast_addr " Joe Perches
2018-07-07 7:40 ` Luciano Coelho
2018-09-07 10:46 ` Luciano Coelho
2018-03-31 7:05 ` [PATCH 10/12] mvpp2: Use ether_broadcast_addr instead of a local array Joe Perches
2018-03-31 7:05 ` [PATCH 11/12] qlogic: Convert local bcast_addr to global ether_broadcast_addr Joe Perches
2018-03-31 7:05 ` [PATCH 12/12] ethernet: Use ether_zero_addr instead of local statics Joe Perches
2018-04-05 13:27 ` [PATCH 00/12] Ethernet: Add and use ether_<type>_addr globals Felix Fietkau
2018-04-05 13:51 ` Joe Perches
2018-04-05 14:05 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522506808.11653.7.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=amitkarwar@gmail$(echo .)com \
--cc=b43-dev@lists$(echo .)infradead.org \
--cc=chunkeey@googlemail$(echo .)com \
--cc=gbhat@marvell$(echo .)com \
--cc=huxm@marvell$(echo .)com \
--cc=jussi.kivilinna@iki$(echo .)fi \
--cc=kvalo@codeaurora$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nishants@marvell$(echo .)com \
--cc=pkshih@realtek$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox