public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat•com>
To: Ashwanth Goli <ashwanth@codeaurora•org>
Cc: netdev@vger•kernel.org, maloney@google•com, edumazet@google•com,
	David Ahern <dsahern@gmail•com>
Subject: Re: ip6-in-ip{4,6} ipsec tunnel issues with 1280 MTU
Date: Thu, 26 Apr 2018 13:51:17 +0200	[thread overview]
Message-ID: <1524743477.2658.38.camel@redhat.com> (raw)
In-Reply-To: <c3a1f2fc545b622bbb362e98313d7eba@codeaurora.org>

Hi,

[fixed CC list]

On Wed, 2018-04-25 at 21:43 +0530, Ashwanth Goli wrote:
> Hi Pablo,

Actually I'm Paolo, but yours is a recurring mistake ;)

> I am noticing an issue similar to the one reported by Alexis Perez 
> [Regression for ip6-in-ip4 IPsec tunnel in 4.14.16]
> 
> In my IPsec setup outer MTU is set to 1280, ip6_setup_cork sees an MTU 
> less than IPV6_MIN_MTU because of the tunnel headers. -EINVAL is being 
> returned as a result of the MTU check that got added with below patch.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/net/ipv6/ip6_output.c?h=v4.14.34&id=8278804e05f6bcfe3fdfea4a404020752ead15a6
> 
> Can we remove this MTU check since your recent patch [ipv6: the entire 
> IPv6 header chain must fit the first fragment] fixes a similar issue?

AFAICS, RFC 2473 implies we can have MTU below 1280 for tunnel devices
so we can probably relax the MTU check for such devices, but I think we
would still need it in the general case.

Cheers,

Paolo

       reply	other threads:[~2018-04-26 11:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <c3a1f2fc545b622bbb362e98313d7eba@codeaurora.org>
2018-04-26 11:51 ` Paolo Abeni [this message]
2018-04-27 11:02   ` ip6-in-ip{4,6} ipsec tunnel issues with 1280 MTU Ashwanth Goli
2018-04-27 14:48     ` David Ahern
2018-04-27 15:44       ` Ashwanth Goli
2018-04-29  1:05         ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1524743477.2658.38.camel@redhat.com \
    --to=pabeni@redhat$(echo .)com \
    --cc=ashwanth@codeaurora$(echo .)org \
    --cc=dsahern@gmail$(echo .)com \
    --cc=edumazet@google$(echo .)com \
    --cc=maloney@google$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox