From: Luca Boccassi <bluca@debian•org>
To: Stefan Bader <stefan.bader@canonical•com>,
net-devel <netdev@vger•kernel.org>
Cc: Stephen Hemminger <stephen@networkplumber•org>,
Christian Ehrhardt <christian.ehrhardt@canonical•com>
Subject: Re: [PATCH] testsuite: Handle large number of kernel options
Date: Wed, 22 Aug 2018 12:02:51 +0100 [thread overview]
Message-ID: <1534935771.5764.109.camel@debian.org> (raw)
In-Reply-To: <1534926698-25163-1-git-send-email-stefan.bader@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
On Wed, 2018-08-22 at 10:31 +0200, Stefan Bader wrote:
> Once there are more than a certain number of kernel config options
> set (this happened for us with kernel 4.17), the method of passing
> those as command line arguments exceeds the maximum number of
> arguments the shell supports. This causes the whole testsuite to
> fail.
> Instead, create a temporary file and modify its contents so that
> the config option variables are exported. Then this file can be
> sourced in before running the tests.
>
> Signed-off-by: Stefan Bader <stefan.bader@canonical•com>
> ---
> testsuite/Makefile | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/testsuite/Makefile b/testsuite/Makefile
> index 8fcbc55..f9f3b19 100644
Acked-by: Luca Boccassi <bluca@debian•org>
Looks good to me, thanks.
--
Kind regards,
Luca Boccassi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2018-08-22 14:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 8:31 [PATCH] testsuite: Handle large number of kernel options Stefan Bader
2018-08-22 11:02 ` Luca Boccassi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1534935771.5764.109.camel@debian.org \
--to=bluca@debian$(echo .)org \
--cc=christian.ehrhardt@canonical$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stefan.bader@canonical$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox