From: Johannes Berg <johannes@sipsolutions•net>
To: David Laight <David.Laight@ACULAB•COM>,
"linux-wireless@vger•kernel.org" <linux-wireless@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Cc: David Ahern <dsahern@gmail•com>
Subject: Re: [PATCH v2 1/5] netlink: remove NLA_NESTED_COMPAT
Date: Thu, 20 Sep 2018 19:06:27 +0200 [thread overview]
Message-ID: <1537463187.3874.34.camel@sipsolutions.net> (raw)
In-Reply-To: <1811E905-CD9B-4346-AF17-CE9DBEBBE4F6@sipsolutions.net>
On Thu, 2018-09-20 at 16:56 +0200, Johannes Berg wrote:
>
>
> > > @@ -172,7 +172,6 @@ enum {
> > > NLA_FLAG,
> > > NLA_MSECS,
> > > NLA_NESTED,
> > > - NLA_NESTED_COMPAT,
> > > NLA_NUL_STRING,
> > > NLA_BINARY,
> > > NLA_S8,
> >
> > ...
> >
> > Is it safe to remove an item from this emun ?
>
> I believe it is, since it's not part of uapi. At least as long as you
> recompile all netlink policies afterwards.
That came out confusing. It isn't UAPI, so the renumbering doesn't
matter, at least as long as you don't try to load a module compiled with
one version of the enum into a kernel compiled with the other, or
something strange like that.
johannes
next prev parent reply other threads:[~2018-09-20 22:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 19:49 [PATCH v2 0/5] netlink: nested policy validation Johannes Berg
[not found] ` <20180919194905.16462-1-johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-09-19 19:49 ` [PATCH v2 1/5] netlink: remove NLA_NESTED_COMPAT Johannes Berg
2018-09-20 14:54 ` David Laight
[not found] ` <15cc8087b97d4b8693fad397b27f4d10-1XygrNkDbNvwg4NCKwmqgw@public.gmane.org>
2018-09-20 14:56 ` Johannes Berg
2018-09-20 17:06 ` Johannes Berg [this message]
2018-09-19 19:49 ` [PATCH v2 2/5] netlink: make validation_data const Johannes Berg
2018-09-19 19:49 ` [PATCH v2 3/5] netlink: move extack setting into validate_nla() Johannes Berg
2018-09-19 19:52 ` Johannes Berg
2018-09-19 19:49 ` [PATCH v2 4/5] netlink: allow NLA_NESTED to specify nested policy to validate Johannes Berg
2018-09-19 19:49 ` [PATCH v2 5/5] netlink: add nested array policy validation Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537463187.3874.34.camel@sipsolutions.net \
--to=johannes@sipsolutions$(echo .)net \
--cc=David.Laight@ACULAB$(echo .)COM \
--cc=dsahern@gmail$(echo .)com \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox