From: Oliver Neukum <oneukum@suse•com>
To: "Bjørn Mork" <bjorn@mork•no>
Cc: Dmitry Bezrukov <Dmitry.Bezrukov@aquantia•com>,
Igor Russkikh <Igor.Russkikh@aquantia•com>,
"David S . Miller" <davem@davemloft•net>,
"linux-usb@vger•kernel.org" <linux-usb@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next 04/19] net: usb: aqc111: Various callbacks implementation
Date: Wed, 10 Oct 2018 13:33:47 +0200 [thread overview]
Message-ID: <1539171227.4371.0.camel@suse.com> (raw)
In-Reply-To: <87efcz9rn1.fsf@miraculix.mork.no>
On Di, 2018-10-09 at 15:27 +0200, Bjørn Mork wrote:
> Oliver Neukum <oneukum@suse•com> writes:
>
> > On Fr, 2018-10-05 at 10:24 +0000, Igor Russkikh wrote:
> > > From: Dmitry Bezrukov <dmitry.bezrukov@aquantia•com>
> > >
> > > Reset, stop callbacks, driver unbind callback.
> > > More register defines required for these callbacks.
> > >
> > > Signed-off-by: Dmitry Bezrukov <dmitry.bezrukov@aquantia•com>
> > > Signed-off-by: Igor Russkikh <igor.russkikh@aquantia•com>
> > > ---
> > > drivers/net/usb/aqc111.c | 48 ++++++++++++++++++++++
> > > drivers/net/usb/aqc111.h | 101 +++++++++++++++++++++++++++++++++++++++++++++++
> > > 2 files changed, 149 insertions(+)
> > >
> > > diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c
> > > index 7f3e5a615750..22bb259d71fb 100644
> > > --- a/drivers/net/usb/aqc111.c
> > > +++ b/drivers/net/usb/aqc111.c
> > > @@ -169,12 +169,60 @@ static int aqc111_bind(struct usbnet *dev, struct usb_interface *intf)
> > >
> > > static void aqc111_unbind(struct usbnet *dev, struct usb_interface *intf)
> > > {
> > > + u8 reg8;
> > > + u16 reg16;
> > > +
> > > + /* Force bz */
> > > + reg16 = SFR_PHYPWR_RSTCTL_BZ;
> > > + aqc111_write_cmd_nopm(dev, AQ_ACCESS_MAC, SFR_PHYPWR_RSTCTL,
> > > + 2, 2, ®16);
> >
> > No, I am sorry, you are doing DMA on the kernel stack. That is not
> > allowed. These functions will all have to be fixed.
>
> Huh? No, he doesn't. That's the whole point with
> usbnet_read_cmd_nopm(), isn't it?
Right. Too many indirections for me.
Please disregard my comment.
Regards
Oliver
next prev parent reply other threads:[~2018-10-10 19:04 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 10:24 [PATCH net-next 00/19] Add support for Aquantia AQtion USB to 5/2.5GbE devices Igor Russkikh
2018-10-05 10:24 ` [PATCH net-next 01/19] net: usb: aqc111: Driver skeleton for Aquantia AQtion USB to 5GbE Igor Russkikh
2018-10-09 13:37 ` Bjørn Mork
2018-10-05 10:24 ` [PATCH net-next 02/19] net: usb: aqc111: Add bind and empty unbind callbacks Igor Russkikh
2018-10-05 17:39 ` David Miller
2018-10-05 10:24 ` [PATCH net-next 03/19] net: usb: aqc111: Add implementation of read and write commands Igor Russkikh
2018-10-05 17:40 ` David Miller
2018-10-08 13:44 ` Oliver Neukum
2018-10-09 13:33 ` Bjørn Mork
2018-10-05 10:24 ` [PATCH net-next 04/19] net: usb: aqc111: Various callbacks implementation Igor Russkikh
2018-10-08 13:47 ` Oliver Neukum
2018-10-09 13:27 ` Bjørn Mork
2018-10-10 11:33 ` Oliver Neukum [this message]
2018-10-05 10:24 ` [PATCH net-next 05/19] net: usb: aqc111: Introduce PHY access Igor Russkikh
2018-10-05 22:04 ` Andrew Lunn
2018-10-08 9:09 ` Igor Russkikh
2018-10-08 12:17 ` Andrew Lunn
2018-10-08 14:07 ` Igor Russkikh
2018-10-10 0:58 ` Andrew Lunn
2018-10-10 7:54 ` Igor Russkikh
2018-10-08 13:52 ` Oliver Neukum
2018-10-08 14:10 ` Igor Russkikh
2018-10-08 14:24 ` Oliver Neukum
2018-10-05 10:24 ` [PATCH net-next 06/19] net: usb: aqc111: Introduce link management Igor Russkikh
2018-10-05 17:11 ` Andrew Lunn
2018-10-08 13:22 ` Igor Russkikh
2018-10-05 17:46 ` David Miller
2018-10-06 17:35 ` Andrew Lunn
2018-10-08 9:29 ` Igor Russkikh
2018-10-08 12:12 ` Andrew Lunn
2018-10-08 13:59 ` Oliver Neukum
2018-10-05 10:24 ` [PATCH net-next 07/19] net: usb: aqc111: Add support for getting and setting of MAC address Igor Russkikh
2018-10-06 1:03 ` Andrew Lunn
2018-10-09 14:34 ` Igor Russkikh
2018-10-09 14:46 ` Andrew Lunn
2018-10-05 10:25 ` [PATCH net-next 08/19] net: usb: aqc111: Implement TX data path Igor Russkikh
2018-10-06 1:13 ` Andrew Lunn
2018-10-08 13:43 ` Igor Russkikh
2018-10-08 14:07 ` Oliver Neukum
2018-10-09 13:50 ` Bjørn Mork
2018-10-05 10:25 ` [PATCH net-next 09/19] net: usb: aqc111: Implement RX " Igor Russkikh
2018-10-06 1:18 ` Andrew Lunn
2018-10-09 13:39 ` Bjørn Mork
2018-10-05 10:25 ` [PATCH net-next 10/19] net: usb: aqc111: Add checksum offload support Igor Russkikh
2018-10-05 10:25 ` [PATCH net-next 11/19] net: usb: aqc111: Add support for changing MTU Igor Russkikh
2018-10-06 16:56 ` Andrew Lunn
2018-10-05 10:25 ` [PATCH net-next 12/19] net: usb: aqc111: Add support for enable/disable checksum offload Igor Russkikh
2018-10-05 10:25 ` [PATCH net-next 13/19] net: usb: aqc111: Add support for TSO Igor Russkikh
2018-10-08 14:12 ` Oliver Neukum
2018-10-05 10:25 ` [PATCH net-next 14/19] net: usb: aqc111: Implement set_rx_mode callback Igor Russkikh
2018-10-06 17:03 ` Andrew Lunn
2018-10-08 13:49 ` Igor Russkikh
2018-10-05 10:25 ` [PATCH net-next 15/19] net: usb: aqc111: Add support for VLAN_CTAG_TX/RX offload Igor Russkikh
2018-10-08 14:14 ` Oliver Neukum
2018-10-05 10:25 ` [PATCH net-next 16/19] net: usb: aqc111: Add RX VLAN filtering support Igor Russkikh
2018-10-06 17:05 ` Andrew Lunn
2018-10-05 10:25 ` [PATCH net-next 17/19] net: usb: aqc111: Initialize ethtool_ops structure Igor Russkikh
2018-10-06 17:08 ` Andrew Lunn
2018-10-05 10:25 ` [PATCH net-next 18/19] net: usb: aqc111: Implement get/set_link_ksettings callbacks Igor Russkikh
2018-10-06 17:38 ` Andrew Lunn
2018-10-08 14:18 ` Oliver Neukum
2018-10-05 10:25 ` [PATCH net-next 19/19] net: usb: aqc111: Add support for wake on LAN by MAGIC packet Igor Russkikh
2018-10-06 17:49 ` Andrew Lunn
2018-10-08 14:12 ` Igor Russkikh
2018-10-08 14:47 ` Andrew Lunn
2018-10-06 17:51 ` [PATCH net-next 00/19] Add support for Aquantia AQtion USB to 5/2.5GbE devices Andrew Lunn
2018-10-08 7:58 ` Igor Russkikh
2018-10-08 14:21 ` Oliver Neukum
2018-10-08 14:52 ` Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1539171227.4371.0.camel@suse.com \
--to=oneukum@suse$(echo .)com \
--cc=Dmitry.Bezrukov@aquantia$(echo .)com \
--cc=Igor.Russkikh@aquantia$(echo .)com \
--cc=bjorn@mork$(echo .)no \
--cc=davem@davemloft$(echo .)net \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox