Subject: Re: [PATCH 19/20] rtlwifi: rtl8821ae: phy: Mark expected switch fall-through

From: Pkshih <[email-masked]>
Date: Tue, 23 Oct 2018 01:24:03 +0000

On Mon, 2018-10-22 at 22:47 +0200, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Signed-off-by: Gustavo A. R. Silva <[email-masked]>
> ---
>  drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
> index 176deb2..a75451c 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
> @@ -394,6 +394,7 @@ static void _rtl8812ae_phy_set_rfe_reg_24g(struct
> ieee80211_hw *hw)
>  			rtl_set_bbreg(hw, RB_RFE_INV, BMASKRFEINV, 0x000);
>  			break;
>  		}
> +		/* fall through */
>  	case 0:
>  	case 2:
>  	default:

If BT isn't coexisting in the case 1, the settings will be the same as case 0/2.

Acked-by: Ping-Ke Shih <[email-masked]>