From: Florian Fainelli <florian@openwrt•org>
To: Joe Perches <joe@perches•com>
Cc: netdev@vger•kernel.org, khc@pm•waw.pl,
David Miller <davem@davemloft•net>,
stable@vger•kernel.org
Subject: Re: [PATCH net] ixp4xx_hss: fix build failure after logging conversion
Date: Mon, 10 Sep 2012 11:35:28 +0200 [thread overview]
Message-ID: <15505259.4Zl8C80Fzd@flexo> (raw)
In-Reply-To: <1347267855.6069.2.camel@joe2Laptop>
On Monday 10 September 2012 02:04:15 Joe Perches wrote:
> On Mon, 2012-09-10 at 10:43 +0200, Florian Fainelli wrote:
> > Commit c75bb2c6f0cf455c23e60f14d780e841dd47f801 (ixp4xx_hss: Update to
> > current logging forms) converted the ixp4xx_hss module to use the current
> > logging macros, but forgot to include linux/module.h, leading to the
> > following build failures:
>
> Bad explanation.
> This commit had nothing to do with any missing module.h.
You are right, this issue dates back from day one when this driver got merged,
I will repost a v2 with the proper commit.
--
Florian
next prev parent reply other threads:[~2012-09-10 9:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 8:43 [PATCH net] ixp4xx_hss: fix build failure after logging conversion Florian Fainelli
2012-09-10 9:04 ` Joe Perches
2012-09-10 9:35 ` Florian Fainelli [this message]
2012-09-10 17:04 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15505259.4Zl8C80Fzd@flexo \
--to=florian@openwrt$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=joe@perches$(echo .)com \
--cc=khc@pm$(echo .)waw.pl \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stable@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox