From: Bart Van Assche <bvanassche@acm•org>
To: "Rustad, Mark D" <mark.d.rustad@intel•com>
Cc: David Miller <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Sagi Grimberg <sagi@grimberg•me>, Christoph Hellwig <hch@lst•de>
Subject: Re: [PATCH 7/7] net/utils: Use strlcpy() instead of open-coding it
Date: Mon, 25 Mar 2019 08:55:05 -0700 [thread overview]
Message-ID: <1553529305.118779.8.camel@acm.org> (raw)
In-Reply-To: <2C668AAE-BB6F-4292-84DD-25D4C6A5BC5F@intel.com>
On Fri, 2019-03-22 at 18:46 +0000, Rustad, Mark D wrote:
> This doesn't look right to me. The original code seemingly would stop the
> copy before getting to a possible '%' character. The new code only stops at
> eol. So this appears to change the functionality and I assume is broken in
> any case that uses the %. Take another look at what that min_t is really
> doing.
Hi Mark,
Thanks for the feedback. I will drop this patch.
Bart.
next prev parent reply other threads:[~2019-03-25 15:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 22:19 [PATCH 0/7] net/core patches for kernel v5.2 Bart Van Assche
2019-03-21 22:19 ` [PATCH 1/7] net/core: Document reuseport_add_sock() bind_inany argument Bart Van Assche
2019-03-21 22:19 ` [PATCH 2/7] net/core: Document all dev_ioctl() arguments Bart Van Assche
2019-03-21 22:19 ` [PATCH 3/7] net/core: Document __skb_flow_dissect() flags argument Bart Van Assche
2019-03-21 22:19 ` [PATCH 4/7] net/core: Fix rtnetlink kernel-doc headers Bart Van Assche
2019-03-21 22:19 ` [PATCH 5/7] net/core: Allow the compiler to verify declaration and definition consistency Bart Van Assche
2019-03-21 22:19 ` [PATCH 6/7] net/core: Declare a local function 'static' Bart Van Assche
2019-03-21 22:25 ` Sagi Grimberg
2019-03-21 22:19 ` [PATCH 7/7] net/utils: Use strlcpy() instead of open-coding it Bart Van Assche
2019-03-21 22:24 ` Sagi Grimberg
2019-03-22 18:46 ` Rustad, Mark D
2019-03-25 15:55 ` Bart Van Assche [this message]
2019-03-24 0:47 ` [PATCH 0/7] net/core patches for kernel v5.2 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553529305.118779.8.camel@acm.org \
--to=bvanassche@acm$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=hch@lst$(echo .)de \
--cc=mark.d.rustad@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sagi@grimberg$(echo .)me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox