Subject: Re: [Question] net: dsa: tag_qca: QCA tag and headroom size?

From: Per Förlin <[email-masked]>
Date: Thu, 13 Feb 2020 05:23:59 +0000

> > -     if (skb_cow_head(skb, 0) < 0)
> > >  Is it really safe to assume there is enough headroom for the QCA tag?
> >
> > +     if (skb_cow_head(skb, QCA_HDR_LEN) < 0)
> > > My proposal. Specify QCA tag size to make sure there is headroom.
> >
> >               return NULL;
> >
> >       skb_push(skb, QCA_HDR_LEN);

> > Hi Per

> > Yes, your change looks correct. ar9331_tag_xmit() also seems to have
> > the same problem.

>> Do you want to submit a patch?
Thanks for your response,
I can submit a patch on both drivers, however I only have hardware to perform an actual test on the QCA switch.