From: Arnd Bergmann <arnd@arndb•de>
To: Johannes Berg <johannes@sipsolutions•net>
Cc: netdev@vger•kernel.org, Greg Ungerer <gerg@uclinux•org>,
Lucas Stach <l.stach@pengutronix•de>,
Fugang Duan <B38611@freescale•com>,
Shawn Guo <shawnguo@kernel•org>
Subject: Re: [PATCH v2] net: fec: use CONFIG_ARM instead of CONFIG_ARCH_MXC/SOC_IMX28
Date: Mon, 25 Jan 2016 11:43:43 +0100 [thread overview]
Message-ID: <1612772.4retUf0a0d@wuerfel> (raw)
In-Reply-To: <1453718450-7250-1-git-send-email-johannes@sipsolutions.net>
On Monday 25 January 2016 11:40:50 Johannes Berg wrote:
> As Arnd Bergmann points out, using CONFIG_ARCH_MXC and/or SOC_IMX28
> is wrong if some other ARM platform uses this device - the operation
> of the driver would depend on an unrelated ARM platform that might
> or might not be set for multi-platform kernels.
>
> Prior to my previous patch, any other platforms using it would have
> been broken already due to having the cbd_datlen/cbd_sc fields in
> the wrong order, but byte ordering correctly, so no such platforms
> can exist and work today.
>
> In any case, it seems likely that only Freescale SoCs use this part,
> and those are little-endian on ARM, so CONFIG_ARM is safe for them.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions•net>
>
Thanks, looks good.
Reviewed-by: Arnd Bergmann <arnd@arndb•de>
next prev parent reply other threads:[~2016-01-25 10:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 10:40 [PATCH v2] net: fec: use CONFIG_ARM instead of CONFIG_ARCH_MXC/SOC_IMX28 Johannes Berg
2016-01-25 10:43 ` Arnd Bergmann [this message]
2016-01-25 18:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1612772.4retUf0a0d@wuerfel \
--to=arnd@arndb$(echo .)de \
--cc=B38611@freescale$(echo .)com \
--cc=gerg@uclinux$(echo .)org \
--cc=johannes@sipsolutions$(echo .)net \
--cc=l.stach@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shawnguo@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox