Subject: Re: [PATCHv2 net] sctp: use call_rcu to free endpoint

From: [email-masked]
Date: Sat, 25 Dec 2021 17:20:09 +0000

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <[email-masked]>:

On Thu, 23 Dec 2021 13:04:30 -0500 you wrote:
> This patch is to delay the endpoint free by calling call_rcu() to fix
> another use-after-free issue in sctp_sock_dump():
> 
>   BUG: KASAN: use-after-free in __lock_acquire+0x36d9/0x4c20
>   Call Trace:
>     __lock_acquire+0x36d9/0x4c20 kernel/locking/lockdep.c:3218
>     lock_acquire+0x1ed/0x520 kernel/locking/lockdep.c:3844
>     __raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
>     _raw_spin_lock_bh+0x31/0x40 kernel/locking/spinlock.c:168
>     spin_lock_bh include/linux/spinlock.h:334 [inline]
>     __lock_sock+0x203/0x350 net/core/sock.c:2253
>     lock_sock_nested+0xfe/0x120 net/core/sock.c:2774
>     lock_sock include/net/sock.h:1492 [inline]
>     sctp_sock_dump+0x122/0xb20 net/sctp/diag.c:324
>     sctp_for_each_transport+0x2b5/0x370 net/sctp/socket.c:5091
>     sctp_diag_dump+0x3ac/0x660 net/sctp/diag.c:527
>     __inet_diag_dump+0xa8/0x140 net/ipv4/inet_diag.c:1049
>     inet_diag_dump+0x9b/0x110 net/ipv4/inet_diag.c:1065
>     netlink_dump+0x606/0x1080 net/netlink/af_netlink.c:2244
>     __netlink_dump_start+0x59a/0x7c0 net/netlink/af_netlink.c:2352
>     netlink_dump_start include/linux/netlink.h:216 [inline]
>     inet_diag_handler_cmd+0x2ce/0x3f0 net/ipv4/inet_diag.c:1170
>     __sock_diag_cmd net/core/sock_diag.c:232 [inline]
>     sock_diag_rcv_msg+0x31d/0x410 net/core/sock_diag.c:263
>     netlink_rcv_skb+0x172/0x440 net/netlink/af_netlink.c:2477
>     sock_diag_rcv+0x2a/0x40 net/core/sock_diag.c:274
> 
> [...]

Here is the summary with links:
  - [PATCHv2,net] sctp: use call_rcu to free endpoint
    https://git.kernel.org/netdev/net/c/5ec7d18d1813

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html