From: patchwork-bot+netdevbpf@kernel•org
To: Marc Kleine-Budde <mkl@pengutronix•de>
Cc: netdev@vger•kernel.org, davem@davemloft•net, kuba@kernel•org,
linux-can@vger•kernel.org, kernel@pengutronix•de,
stable@vger•kernel.org
Subject: Re: [PATCH net 1/2] can: gs_usb: fix use of uninitialized variable, detach device on reception of invalid USB data
Date: Thu, 06 Jan 2022 01:20:09 +0000 [thread overview]
Message-ID: <164143200962.6490.5453127499700459621.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220105205443.1274709-2-mkl@pengutronix.de>
Hello:
This series was applied to netdev/net.git (master)
by Marc Kleine-Budde <mkl@pengutronix•de>:
On Wed, 5 Jan 2022 21:54:42 +0100 you wrote:
> The received data contains the channel the received data is associated
> with. If the channel number is bigger than the actual number of
> channels assume broken or malicious USB device and shut it down.
>
> This fixes the error found by clang:
>
> | drivers/net/can/usb/gs_usb.c:386:6: error: variable 'dev' is used
> | uninitialized whenever 'if' condition is true
> | if (hf->channel >= GS_MAX_INTF)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> | drivers/net/can/usb/gs_usb.c:474:10: note: uninitialized use occurs here
> | hf, dev->gs_hf_size, gs_usb_receive_bulk_callback,
> | ^~~
>
> [...]
Here is the summary with links:
- [net,1/2] can: gs_usb: fix use of uninitialized variable, detach device on reception of invalid USB data
https://git.kernel.org/netdev/net/c/4a8737ff0687
- [net,2/2] can: isotp: convert struct tpcon::{idx,len} to unsigned int
https://git.kernel.org/netdev/net/c/5f33a09e769a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2022-01-06 1:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 20:54 [PATCH net 0/2] pull-request: can 2022-01-05 Marc Kleine-Budde
2022-01-05 20:54 ` [PATCH net 1/2] can: gs_usb: fix use of uninitialized variable, detach device on reception of invalid USB data Marc Kleine-Budde
2022-01-06 1:20 ` patchwork-bot+netdevbpf [this message]
2022-01-05 20:54 ` [PATCH net 2/2] can: isotp: convert struct tpcon::{idx,len} to unsigned int Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164143200962.6490.5453127499700459621.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=kernel@pengutronix$(echo .)de \
--cc=kuba@kernel$(echo .)org \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=mkl@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stable@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox