Subject: Re: [PATCH] micrel: fix masking off LED bits

From: Laurent Pinchart <[email-masked]>
Date: Wed, 19 Mar 2014 00:27:41 +0100

Hi Sergei,

Thank you for the patch.

On Wednesday 19 March 2014 02:58:16 Sergei Shtylyov wrote:
> Commit 20d8435a1cff (phy: micrel: add of configuration for LED mode) made
> the obvious mistake when masking off  the LED mode bits: forgot to do a
> logical NOT to the mask with which it ANDs the register value, so that
> unrelated bits are cleared instead.
> 
> Signed-off-by: Sergei Shtylyov <[email-masked]>

Good catch.

Acked-by: Laurent Pinchart <[email-masked]>

> ---
> This patch is against DaveM's 'net-next.git' repo.
> 
>  drivers/net/phy/micrel.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: net-next/drivers/net/phy/micrel.c
> ===================================================================
> --- net-next.orig/drivers/net/phy/micrel.c
> +++ net-next/drivers/net/phy/micrel.c
> @@ -167,7 +167,7 @@ static int kszphy_setup_led(struct phy_d
>  	if (temp < 0)
>  		return temp;
> 
> -	temp &= 3 << shift;
> +	temp &= ~(3 << shift);
>  	temp |= val << shift;
>  	rc = phy_write(phydev, reg, temp);

-- 
Regards,

Laurent Pinchart