From: patchwork-bot+netdevbpf@kernel•org
To: Dan Carpenter <dan.carpenter@oracle•com>
Cc: peppe.cavallaro@st•com, boon.leong.ong@intel•com,
alexandre.torgue@foss•st.com, joabreu@synopsys•com,
davem@davemloft•net, kuba@kernel•org, mcoquelin.stm32@gmail•com,
netdev@vger•kernel.org, linux-stm32@st-md-mailman•stormreply.com,
kernel-janitors@vger•kernel.org
Subject: Re: [PATCH net-next] net: stmmac: clean up impossible condition
Date: Thu, 17 Mar 2022 13:00:10 +0000 [thread overview]
Message-ID: <164752201035.1459.5576780774534521056.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220316083744.GB30941@kili>
Hello:
This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat•com>:
On Wed, 16 Mar 2022 11:37:44 +0300 you wrote:
> This code works but it has a static checker warning:
>
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1687 init_dma_rx_desc_rings()
> warn: always true condition '(queue >= 0) => (0-u32max >= 0)'
>
> Obviously, it makes no sense to check if an unsigned int is >= 0. What
> prevents this code from being a forever loop is that later there is a
> separate check for if (queue == 0).
>
> [...]
Here is the summary with links:
- [net-next] net: stmmac: clean up impossible condition
https://git.kernel.org/netdev/net-next/c/58e06d05d43a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-03-17 13:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 8:37 [PATCH net-next] net: stmmac: clean up impossible condition Dan Carpenter
2022-03-17 13:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164752201035.1459.5576780774534521056.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=boon.leong.ong@intel$(echo .)com \
--cc=dan.carpenter@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=joabreu@synopsys$(echo .)com \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peppe.cavallaro@st$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox