From: patchwork-bot+netdevbpf@kernel•org
To: Liu Jian <liujian56@huawei•com>
Cc: john.fastabend@gmail•com, jakub@cloudflare•com,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, ast@kernel•org, daniel@iogearbox•net,
andrii@kernel•org, kafai@fb•com, songliubraving@fb•com,
yhs@fb•com, kpsingh@kernel•org, netdev@vger•kernel.org,
bpf@vger•kernel.org
Subject: Re: [PATCH bpf] skmsg: Fix invalid last sg check in sk_msg_recvmsg()
Date: Mon, 11 Jul 2022 16:30:14 +0000 [thread overview]
Message-ID: <165755701430.14376.9886144012475004579.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220628123616.186950-1-liujian56@huawei.com>
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox•net>:
On Tue, 28 Jun 2022 20:36:16 +0800 you wrote:
> In sk_psock_skb_ingress_enqueue function, if the linear area + nr_frags +
> frag_list of the SKB has NR_MSG_FRAG_IDS blocks in total, skb_to_sgvec
> will return NR_MSG_FRAG_IDS, then msg->sg.end will be set to
> NR_MSG_FRAG_IDS, and in addition, (NR_MSG_FRAG_IDS - 1) is set to the last
> SG of msg. Recv the msg in sk_msg_recvmsg, when i is (NR_MSG_FRAG_IDS - 1),
> the sk_msg_iter_var_next(i) will change i to 0 (not NR_MSG_FRAG_IDS), the
> judgment condition "msg_rx->sg.start==msg_rx->sg.end" and
> "i != msg_rx->sg.end" can not work.
>
> [...]
Here is the summary with links:
- [bpf] skmsg: Fix invalid last sg check in sk_msg_recvmsg()
https://git.kernel.org/bpf/bpf-next/c/9974d37ea75f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-07-11 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 12:36 [PATCH bpf] skmsg: Fix invalid last sg check in sk_msg_recvmsg() Liu Jian
2022-06-30 7:29 ` John Fastabend
2022-07-01 20:30 ` John Fastabend
2022-07-11 16:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165755701430.14376.9886144012475004579.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=andrii@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jakub@cloudflare$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kafai@fb$(echo .)com \
--cc=kpsingh@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=liujian56@huawei$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=songliubraving@fb$(echo .)com \
--cc=yhs@fb$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox