* [PATCH net] bridge: Fix flushing of dynamic FDB entries
@ 2022-11-01 18:57 Ido Schimmel
2022-11-01 19:04 ` Nikolay Aleksandrov
2022-11-03 4:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Ido Schimmel @ 2022-11-01 18:57 UTC (permalink / raw)
To: netdev, bridge
Cc: davem, kuba, pabeni, edumazet, roopa, razor, mlxsw, Ido Schimmel
The following commands should result in all the dynamic FDB entries
being flushed, but instead all the non-local (non-permanent) entries are
flushed:
# bridge fdb add 00:aa:bb:cc:dd:ee dev dummy1 master static
# bridge fdb add 00:11:22:33:44:55 dev dummy1 master dynamic
# ip link set dev br0 type bridge fdb_flush
# bridge fdb show brport dummy1
00:00:00:00:00:01 master br0 permanent
33:33:00:00:00:01 self permanent
01:00:5e:00:00:01 self permanent
This is because br_fdb_flush() works with FDB flags and not the
corresponding enumerator values. Fix by passing the FDB flag instead.
After the fix:
# bridge fdb add 00:aa:bb:cc:dd:ee dev dummy1 master static
# bridge fdb add 00:11:22:33:44:55 dev dummy1 master dynamic
# ip link set dev br0 type bridge fdb_flush
# bridge fdb show brport dummy1
00:aa:bb:cc:dd:ee master br0 static
00:00:00:00:00:01 master br0 permanent
33:33:00:00:00:01 self permanent
01:00:5e:00:00:01 self permanent
Fixes: 1f78ee14eeac ("net: bridge: fdb: add support for fine-grained flushing")
Signed-off-by: Ido Schimmel <idosch@nvidia•com>
---
net/bridge/br_netlink.c | 2 +-
net/bridge/br_sysfs_br.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index 5aeb3646e74c..d087fd4c784a 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -1332,7 +1332,7 @@ static int br_changelink(struct net_device *brdev, struct nlattr *tb[],
if (data[IFLA_BR_FDB_FLUSH]) {
struct net_bridge_fdb_flush_desc desc = {
- .flags_mask = BR_FDB_STATIC
+ .flags_mask = BIT(BR_FDB_STATIC)
};
br_fdb_flush(br, &desc);
diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c
index 612e367fff20..ea733542244c 100644
--- a/net/bridge/br_sysfs_br.c
+++ b/net/bridge/br_sysfs_br.c
@@ -345,7 +345,7 @@ static int set_flush(struct net_bridge *br, unsigned long val,
struct netlink_ext_ack *extack)
{
struct net_bridge_fdb_flush_desc desc = {
- .flags_mask = BR_FDB_STATIC
+ .flags_mask = BIT(BR_FDB_STATIC)
};
br_fdb_flush(br, &desc);
--
2.37.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] bridge: Fix flushing of dynamic FDB entries
2022-11-01 18:57 [PATCH net] bridge: Fix flushing of dynamic FDB entries Ido Schimmel
@ 2022-11-01 19:04 ` Nikolay Aleksandrov
2022-11-03 4:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Nikolay Aleksandrov @ 2022-11-01 19:04 UTC (permalink / raw)
To: Ido Schimmel, netdev, bridge; +Cc: davem, kuba, pabeni, edumazet, roopa, mlxsw
On 1 November 2022 20:57:53 EET, Ido Schimmel <idosch@nvidia•com> wrote:
>The following commands should result in all the dynamic FDB entries
>being flushed, but instead all the non-local (non-permanent) entries are
>flushed:
>
> # bridge fdb add 00:aa:bb:cc:dd:ee dev dummy1 master static
> # bridge fdb add 00:11:22:33:44:55 dev dummy1 master dynamic
> # ip link set dev br0 type bridge fdb_flush
> # bridge fdb show brport dummy1
> 00:00:00:00:00:01 master br0 permanent
> 33:33:00:00:00:01 self permanent
> 01:00:5e:00:00:01 self permanent
>
>This is because br_fdb_flush() works with FDB flags and not the
>corresponding enumerator values. Fix by passing the FDB flag instead.
>
>After the fix:
>
> # bridge fdb add 00:aa:bb:cc:dd:ee dev dummy1 master static
> # bridge fdb add 00:11:22:33:44:55 dev dummy1 master dynamic
> # ip link set dev br0 type bridge fdb_flush
> # bridge fdb show brport dummy1
> 00:aa:bb:cc:dd:ee master br0 static
> 00:00:00:00:00:01 master br0 permanent
> 33:33:00:00:00:01 self permanent
> 01:00:5e:00:00:01 self permanent
>
>Fixes: 1f78ee14eeac ("net: bridge: fdb: add support for fine-grained flushing")
>Signed-off-by: Ido Schimmel <idosch@nvidia•com>
>---
> net/bridge/br_netlink.c | 2 +-
> net/bridge/br_sysfs_br.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
>index 5aeb3646e74c..d087fd4c784a 100644
>--- a/net/bridge/br_netlink.c
>+++ b/net/bridge/br_netlink.c
>@@ -1332,7 +1332,7 @@ static int br_changelink(struct net_device *brdev, struct nlattr *tb[],
>
> if (data[IFLA_BR_FDB_FLUSH]) {
> struct net_bridge_fdb_flush_desc desc = {
>- .flags_mask = BR_FDB_STATIC
>+ .flags_mask = BIT(BR_FDB_STATIC)
> };
>
> br_fdb_flush(br, &desc);
>diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c
>index 612e367fff20..ea733542244c 100644
>--- a/net/bridge/br_sysfs_br.c
>+++ b/net/bridge/br_sysfs_br.c
>@@ -345,7 +345,7 @@ static int set_flush(struct net_bridge *br, unsigned long val,
> struct netlink_ext_ack *extack)
> {
> struct net_bridge_fdb_flush_desc desc = {
>- .flags_mask = BR_FDB_STATIC
>+ .flags_mask = BIT(BR_FDB_STATIC)
> };
>
> br_fdb_flush(br, &desc);
Oops. :)
Acked-by: Nikolay Aleksandrov <razor@blackwall•org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] bridge: Fix flushing of dynamic FDB entries
2022-11-01 18:57 [PATCH net] bridge: Fix flushing of dynamic FDB entries Ido Schimmel
2022-11-01 19:04 ` Nikolay Aleksandrov
@ 2022-11-03 4:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-11-03 4:00 UTC (permalink / raw)
To: Ido Schimmel
Cc: netdev, bridge, davem, kuba, pabeni, edumazet, roopa, razor,
mlxsw
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel•org>:
On Tue, 1 Nov 2022 20:57:53 +0200 you wrote:
> The following commands should result in all the dynamic FDB entries
> being flushed, but instead all the non-local (non-permanent) entries are
> flushed:
>
> # bridge fdb add 00:aa:bb:cc:dd:ee dev dummy1 master static
> # bridge fdb add 00:11:22:33:44:55 dev dummy1 master dynamic
> # ip link set dev br0 type bridge fdb_flush
> # bridge fdb show brport dummy1
> 00:00:00:00:00:01 master br0 permanent
> 33:33:00:00:00:01 self permanent
> 01:00:5e:00:00:01 self permanent
>
> [...]
Here is the summary with links:
- [net] bridge: Fix flushing of dynamic FDB entries
https://git.kernel.org/netdev/net/c/628ac04a75ed
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-03 4:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-01 18:57 [PATCH net] bridge: Fix flushing of dynamic FDB entries Ido Schimmel
2022-11-01 19:04 ` Nikolay Aleksandrov
2022-11-03 4:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox