public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel•org
To: Eric Dumazet <edumazet@google•com>
Cc: davem@davemloft•net, kuba@kernel•org, pabeni@redhat•com,
	netdev@vger•kernel.org, eric.dumazet@gmail•com,
	syzkaller@googlegroups•com, jakub@cloudflare•com,
	john.fastabend@gmail•com, ast@kernel•org, daniel@iogearbox•net,
	songliubraving@fb•com
Subject: Re: [PATCH net] bpf, sockmap: fix race in sock_map_free()
Date: Mon, 05 Dec 2022 03:00:15 +0000	[thread overview]
Message-ID: <167020921526.5137.6945967136915134698.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20221202111640.2745533-1-edumazet@google.com>

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel•org>:

On Fri,  2 Dec 2022 11:16:40 +0000 you wrote:
> sock_map_free() calls release_sock(sk) without owning a reference
> on the socket. This can cause use-after-free as syzbot found [1]
> 
> Jakub Sitnicki already took care of a similar issue
> in sock_hash_free() in commit 75e68e5bf2c7 ("bpf, sockhash:
> Synchronize delete from bucket list on map free")
> 
> [...]

Here is the summary with links:
  - [net] bpf, sockmap: fix race in sock_map_free()
    https://git.kernel.org/bpf/bpf-next/c/0a182f8d6074

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2022-12-05  3:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02 11:16 [PATCH net] bpf, sockmap: fix race in sock_map_free() Eric Dumazet
2022-12-03 19:24 ` John Fastabend
2022-12-05  3:00 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=167020921526.5137.6945967136915134698.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel$(echo .)org \
    --cc=ast@kernel$(echo .)org \
    --cc=daniel@iogearbox$(echo .)net \
    --cc=davem@davemloft$(echo .)net \
    --cc=edumazet@google$(echo .)com \
    --cc=eric.dumazet@gmail$(echo .)com \
    --cc=jakub@cloudflare$(echo .)com \
    --cc=john.fastabend@gmail$(echo .)com \
    --cc=kuba@kernel$(echo .)org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=pabeni@redhat$(echo .)com \
    --cc=songliubraving@fb$(echo .)com \
    --cc=syzkaller@googlegroups$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox