From: patchwork-bot+netdevbpf@kernel•org
To: Benjamin Coddington <bcodding@redhat•com>
Cc: kuba@kernel•org, pabeni@redhat•com, davem@davemloft•net,
edumazet@google•com, gnault@redhat•com,
philipp.reisner@linbit•com, lars.ellenberg@linbit•com,
christoph.boehmwalder@linbit•com, axboe@kernel•dk,
josef@toxicpanda•com, kbusch@kernel•org, hch@lst•de,
sagi@grimberg•me, lduncan@suse•com, cleech@redhat•com,
michael.christie@oracle•com, jejb@linux•ibm.com,
martin.petersen@oracle•com, valentina.manea.m@gmail•com,
shuah@kernel•org, gregkh@linuxfoundation•org,
dhowells@redhat•com, marc.dionne@auristor•com, sfrench@samba•org,
ccaulfie@redhat•com, teigland@redhat•com, mark@fasheh•com,
jlbec@evilplan•org, joseph.qi@linux•alibaba.com,
ericvh@gmail•com, lucho@ionkov•net, asmadeus@codewreck•org,
idryomov@gmail•com, xiubli@redhat•com, chuck.lever@oracle•com,
jlayton@kernel•org, trond.myklebust@hammerspace•com,
anna@kernel•org, steffen.klassert@secunet•com,
herbert@gondor•apana.org.au, netdev@vger•kernel.org
Subject: Re: [PATCH net v4 0/3] Stop corrupting socket's task_frag
Date: Tue, 20 Dec 2022 02:00:18 +0000 [thread overview]
Message-ID: <167150161804.12144.10678918322363818868.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <cover.1671194454.git.bcodding@redhat.com>
Hello:
This series was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel•org>:
On Fri, 16 Dec 2022 07:45:25 -0500 you wrote:
> The networking code uses flags in sk_allocation to determine if it can use
> current->task_frag, however in-kernel users of sockets may stop setting
> sk_allocation when they convert to the preferred memalloc_nofs_save/restore,
> as SUNRPC has done in commit a1231fda7e94 ("SUNRPC: Set memalloc_nofs_save()
> on all rpciod/xprtiod jobs").
>
> This will cause corruption in current->task_frag when recursing into the
> network layer for those subsystems during page fault or reclaim. The
> corruption is difficult to diagnose because stack traces may not contain the
> offending subsystem at all. The corruption is unlikely to show up in
> testing because it requires memory pressure, and so subsystems that
> convert to memalloc_nofs_save/restore are likely to continue to run into
> this issue.
>
> [...]
Here is the summary with links:
- [net,v4,1/3] net: Introduce sk_use_task_frag in struct sock.
https://git.kernel.org/netdev/net/c/fb87bd47516d
- [net,v4,2/3] Treewide: Stop corrupting socket's task_frag
https://git.kernel.org/netdev/net/c/98123866fcf3
- [net,v4,3/3] net: simplify sk_page_frag
https://git.kernel.org/netdev/net/c/08f65892c5ee
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-12-20 2:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 12:45 [PATCH net v4 0/3] Stop corrupting socket's task_frag Benjamin Coddington
2022-12-16 12:45 ` [PATCH net v4 1/3] net: Introduce sk_use_task_frag in struct sock Benjamin Coddington
2022-12-16 12:45 ` [PATCH net v4 2/3] Treewide: Stop corrupting socket's task_frag Benjamin Coddington
2023-01-03 14:26 ` Eric Dumazet
2023-01-03 15:14 ` Guillaume Nault
2023-01-03 16:10 ` Eric Dumazet
2023-01-03 22:37 ` Guillaume Nault
2022-12-16 12:45 ` [PATCH net v4 3/3] net: simplify sk_page_frag Benjamin Coddington
2022-12-20 2:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167150161804.12144.10678918322363818868.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=anna@kernel$(echo .)org \
--cc=asmadeus@codewreck$(echo .)org \
--cc=axboe@kernel$(echo .)dk \
--cc=bcodding@redhat$(echo .)com \
--cc=ccaulfie@redhat$(echo .)com \
--cc=christoph.boehmwalder@linbit$(echo .)com \
--cc=chuck.lever@oracle$(echo .)com \
--cc=cleech@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dhowells@redhat$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=ericvh@gmail$(echo .)com \
--cc=gnault@redhat$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hch@lst$(echo .)de \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=idryomov@gmail$(echo .)com \
--cc=jejb@linux$(echo .)ibm.com \
--cc=jlayton@kernel$(echo .)org \
--cc=jlbec@evilplan$(echo .)org \
--cc=josef@toxicpanda$(echo .)com \
--cc=joseph.qi@linux$(echo .)alibaba.com \
--cc=kbusch@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=lars.ellenberg@linbit$(echo .)com \
--cc=lduncan@suse$(echo .)com \
--cc=lucho@ionkov$(echo .)net \
--cc=marc.dionne@auristor$(echo .)com \
--cc=mark@fasheh$(echo .)com \
--cc=martin.petersen@oracle$(echo .)com \
--cc=michael.christie@oracle$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=philipp.reisner@linbit$(echo .)com \
--cc=sagi@grimberg$(echo .)me \
--cc=sfrench@samba$(echo .)org \
--cc=shuah@kernel$(echo .)org \
--cc=steffen.klassert@secunet$(echo .)com \
--cc=teigland@redhat$(echo .)com \
--cc=trond.myklebust@hammerspace$(echo .)com \
--cc=valentina.manea.m@gmail$(echo .)com \
--cc=xiubli@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox