From: patchwork-bot+netdevbpf@kernel•org
To: Caleb Sander <csander@purestorage•com>
Cc: aelior@marvell•com, manishc@marvell•com, pabeni@redhat•com,
leon@kernel•org, netdev@vger•kernel.org, joern@purestorage•com,
palok@marvell•com
Subject: Re: [PATCH net v3] qed: allow sleep in qed_mcp_trace_dump()
Date: Thu, 05 Jan 2023 04:44:11 +0000 [thread overview]
Message-ID: <167289385153.19861.5654918832967601296.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230103233021.1457646-1-csander@purestorage.com>
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel•org>:
On Tue, 3 Jan 2023 16:30:21 -0700 you wrote:
> By default, qed_mcp_cmd_and_union() delays 10us at a time in a loop
> that can run 500K times, so calls to qed_mcp_nvm_rd_cmd()
> may block the current thread for over 5s.
> We observed thread scheduling delays over 700ms in production,
> with stacktraces pointing to this code as the culprit.
>
> qed_mcp_trace_dump() is called from ethtool, so sleeping is permitted.
> It already can sleep in qed_mcp_halt(), which calls qed_mcp_cmd().
> Add a "can sleep" parameter to qed_find_nvram_image() and
> qed_nvram_read() so they can sleep during qed_mcp_trace_dump().
> qed_mcp_trace_get_meta_info() and qed_mcp_trace_read_meta(),
> called only by qed_mcp_trace_dump(), allow these functions to sleep.
> I can't tell if the other caller (qed_grc_dump_mcp_hw_dump()) can sleep,
> so keep b_can_sleep set to false when it calls these functions.
>
> [...]
Here is the summary with links:
- [net,v3] qed: allow sleep in qed_mcp_trace_dump()
https://git.kernel.org/netdev/net/c/5401c3e09928
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2023-01-05 4:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 17:56 [PATCH] qed: allow sleep in qed_mcp_trace_dump() Caleb Sander
2022-12-20 9:55 ` Paolo Abeni
2022-12-21 16:48 ` Caleb Sander
2022-12-28 22:00 ` [PATCH net v2] " Caleb Sander
2022-12-29 6:52 ` Leon Romanovsky
2023-01-03 23:30 ` [PATCH net v3] " Caleb Sander
2023-01-05 4:44 ` patchwork-bot+netdevbpf [this message]
[not found] ` <PH0PR18MB516573B4C93F1A0CC27D5818C4E49@PH0PR18MB5165.namprd18.prod.outlook.com>
2022-12-22 9:38 ` [PATCH] " Alok Prasad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167289385153.19861.5654918832967601296.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=aelior@marvell$(echo .)com \
--cc=csander@purestorage$(echo .)com \
--cc=joern@purestorage$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=manishc@marvell$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=palok@marvell$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox