From: patchwork-bot+bluetooth@kernel•org
To: Kees Cook <keescook@chromium•org>
Cc: luiz.von.dentz@intel•com, marcel@holtmann•org,
johan.hedberg@gmail•com, davem@davemloft•net,
edumazet@google•com, kuba@kernel•org, pabeni@redhat•com,
linux-bluetooth@vger•kernel.org, netdev@vger•kernel.org,
luiz.dentz@gmail•com, linux-kernel@vger•kernel.org,
linux-hardening@vger•kernel.org
Subject: Re: [PATCH] Bluetooth: hci_conn: Refactor hci_bind_bis() since it always succeeds
Date: Mon, 30 Jan 2023 21:30:17 +0000 [thread overview]
Message-ID: <167511421740.28875.16343473654299319606.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230128005150.never.909-kees@kernel.org>
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel•com>:
On Fri, 27 Jan 2023 16:51:54 -0800 you wrote:
> The compiler thinks "conn" might be NULL after a call to hci_bind_bis(),
> which cannot happen. Avoid any confusion by just making it not return a
> value since it cannot fail. Fixes the warnings seen with GCC 13:
>
> In function 'arch_atomic_dec_and_test',
> inlined from 'atomic_dec_and_test' at ../include/linux/atomic/atomic-instrumented.h:576:9,
> inlined from 'hci_conn_drop' at ../include/net/bluetooth/hci_core.h:1391:6,
> inlined from 'hci_connect_bis' at ../net/bluetooth/hci_conn.c:2124:3:
> ../arch/x86/include/asm/rmwcc.h:37:9: warning: array subscript 0 is outside array bounds of 'atomic_t[0]' [-Warray-bounds=]
> 37 | asm volatile (fullop CC_SET(cc) \
> | ^~~
> ...
> In function 'hci_connect_bis':
> cc1: note: source object is likely at address zero
>
> [...]
Here is the summary with links:
- Bluetooth: hci_conn: Refactor hci_bind_bis() since it always succeeds
https://git.kernel.org/bluetooth/bluetooth-next/c/d57d873e6851
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-01-30 21:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-28 0:51 [PATCH] Bluetooth: hci_conn: Refactor hci_bind_bis() since it always succeeds Kees Cook
2023-01-28 13:44 ` Simon Horman
2023-01-30 21:30 ` patchwork-bot+bluetooth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167511421740.28875.16343473654299319606.git-patchwork-notify@kernel.org \
--to=patchwork-bot+bluetooth@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=johan.hedberg@gmail$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-bluetooth@vger$(echo .)kernel.org \
--cc=linux-hardening@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=luiz.dentz@gmail$(echo .)com \
--cc=luiz.von.dentz@intel$(echo .)com \
--cc=marcel@holtmann$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox