From: patchwork-bot+netdevbpf@kernel•org
To: Jakub Kicinski <kuba@kernel•org>
Cc: davem@davemloft•net, netdev@vger•kernel.org, edumazet@google•com,
pabeni@redhat•com, bluetlh@gmail•com, kuniyu@amazon•co.jp,
gongruiqi1@huawei•com, rshearma@brocade•com
Subject: Re: [PATCH net] net: mpls: fix stale pointer if allocation fails during device rename
Date: Wed, 15 Feb 2023 10:30:18 +0000 [thread overview]
Message-ID: <167645701804.29620.16187922516857113249.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230214065355.358890-1-kuba@kernel.org>
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft•net>:
On Mon, 13 Feb 2023 22:53:55 -0800 you wrote:
> lianhui reports that when MPLS fails to register the sysctl table
> under new location (during device rename) the old pointers won't
> get overwritten and may be freed again (double free).
>
> Handle this gracefully. The best option would be unregistering
> the MPLS from the device completely on failure, but unfortunately
> mpls_ifdown() can fail. So failing fully is also unreliable.
>
> [...]
Here is the summary with links:
- [net] net: mpls: fix stale pointer if allocation fails during device rename
https://git.kernel.org/netdev/net/c/fda6c89fe3d9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-02-15 10:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 6:53 [PATCH net] net: mpls: fix stale pointer if allocation fails during device rename Jakub Kicinski
2023-02-14 9:33 ` Gong Ruiqi
2023-02-14 21:23 ` Jakub Kicinski
2023-02-15 6:29 ` Gong Ruiqi
2023-02-15 10:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167645701804.29620.16187922516857113249.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=bluetlh@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gongruiqi1@huawei$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kuniyu@amazon$(echo .)co.jp \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=rshearma@brocade$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox