From: patchwork-bot+netdevbpf@kernel•org
To: Russell King (Oracle) <rmk+kernel@armlinux•org.uk>
Cc: andrew@lunn•ch, hkallweit1@gmail•com, davem@davemloft•net,
edumazet@google•com, kuba@kernel•org, pabeni@redhat•com,
netdev@vger•kernel.org
Subject: Re: [PATCH net] net: sfp: fix state loss when updating state_hw_mask
Date: Sun, 19 Mar 2023 11:10:16 +0000 [thread overview]
Message-ID: <167922421698.31905.11495733031560601244.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <E1pd4VM-00DjWW-2N@rmk-PC.armlinux.org.uk>
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft•net>:
On Fri, 17 Mar 2023 07:28:00 +0000 you wrote:
> Andrew reports that the SFF modules on one of the ZII platforms do not
> indicate link up due to the SFP code believing that LOS indicating that
> there is no signal being received from the remote end, but in fact the
> LOS signal is showing that there is signal.
>
> What makes SFF modules different from SFPs is they typically have an
> inverted LOS, which uncovered this issue. When we read the hardware
> state, we mask it with state_hw_mask so we ignore anything we're not
> interested in. However, we don't re-read when state_hw_mask changes,
> leading to sfp->state being stale.
>
> [...]
Here is the summary with links:
- [net] net: sfp: fix state loss when updating state_hw_mask
https://git.kernel.org/netdev/net/c/04361b8bb818
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2023-03-19 11:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 7:28 [PATCH net] net: sfp: fix state loss when updating state_hw_mask Russell King (Oracle)
2023-03-19 11:10 ` patchwork-bot+netdevbpf [this message]
2023-06-03 18:22 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167922421698.31905.11495733031560601244.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=rmk+kernel@armlinux$(echo .)org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox