From: patchwork-bot+netdevbpf@kernel•org
To: Russell King (Oracle) <rmk+kernel@armlinux•org.uk>
Cc: andrew@lunn•ch, hkallweit1@gmail•com, davem@davemloft•net,
edumazet@google•com, kuba@kernel•org, pabeni@redhat•com,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next] net: phy: avoid kernel warning dump when stopping an errored PHY
Date: Wed, 24 May 2023 07:30:21 +0000 [thread overview]
Message-ID: <168491342116.25320.7763841866419843305.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <E1q17vE-007Baz-8c@rmk-PC.armlinux.org.uk>
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft•net>:
On Mon, 22 May 2023 16:58:08 +0100 you wrote:
> When taking a network interface down (or removing a SFP module) after
> the PHY has encountered an error, phy_stop() complains incorrectly
> that it was called from HALTED state.
>
> The reason this is incorrect is that the network driver will have
> called phy_start() when the interface was brought up, and the fact
> that the PHY has a problem bears no relationship to the administrative
> state of the interface. Taking the interface administratively down
> (which calls phy_stop()) is always the right thing to do after a
> successful phy_start() call, whether or not the PHY has encountered
> an error.
>
> [...]
Here is the summary with links:
- [net-next] net: phy: avoid kernel warning dump when stopping an errored PHY
https://git.kernel.org/netdev/net-next/c/59088b5a946e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-05-24 7:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 15:58 [PATCH net-next] net: phy: avoid kernel warning dump when stopping an errored PHY Russell King (Oracle)
2023-05-22 16:06 ` Russell King (Oracle)
2023-05-22 19:03 ` Florian Fainelli
2023-09-04 9:50 ` Jijie Shao
2023-09-04 13:43 ` Andrew Lunn
2023-09-05 8:49 ` Jijie Shao
2023-09-05 12:09 ` Andrew Lunn
2023-09-05 14:00 ` Russell King (Oracle)
2023-09-05 13:48 ` Russell King (Oracle)
2023-09-05 15:24 ` Russell King (Oracle)
2023-09-06 12:59 ` Andrew Lunn
2023-09-04 14:42 ` Russell King (Oracle)
2023-09-05 8:59 ` Jijie Shao
2023-05-24 7:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168491342116.25320.7763841866419843305.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=rmk+kernel@armlinux$(echo .)org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox