From: patchwork-bot+netdevbpf@kernel•org
To: fuyuanli <fuyuanli@didiglobal•com>
Cc: edumazet@google•com, davem@davemloft•net, dsahern@kernel•org,
kuba@kernel•org, pabeni@redhat•com, ncardwell@google•com,
ycheng@google•com, toke@toke•dk, netdev@vger•kernel.org,
zhangweiping@didiglobal•com, tiozhang@didiglobal•com,
kerneljasonxing@gmail•com
Subject: Re: [PATCH net v4] tcp: fix mishandling when the sack compression is deferred.
Date: Thu, 01 Jun 2023 11:30:19 +0000 [thread overview]
Message-ID: <168561901927.15218.5820204567180741386.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230531080150.GA20424@didi-ThinkCentre-M920t-N000>
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat•com>:
On Wed, 31 May 2023 16:01:50 +0800 you wrote:
> In this patch, we mainly try to handle sending a compressed ack
> correctly if it's deferred.
>
> Here are more details in the old logic:
> When sack compression is triggered in the tcp_compressed_ack_kick(),
> if the sock is owned by user, it will set TCP_DELACK_TIMER_DEFERRED
> and then defer to the release cb phrase. Later once user releases
> the sock, tcp_delack_timer_handler() should send a ack as expected,
> which, however, cannot happen due to lack of ICSK_ACK_TIMER flag.
> Therefore, the receiver would not sent an ack until the sender's
> retransmission timeout. It definitely increases unnecessary latency.
>
> [...]
Here is the summary with links:
- [net,v4] tcp: fix mishandling when the sack compression is deferred.
https://git.kernel.org/netdev/net/c/30c6f0bf9579
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-06-01 11:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 8:01 [PATCH net v4] tcp: fix mishandling when the sack compression is deferred fuyuanli
2023-06-01 11:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168561901927.15218.5820204567180741386.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=fuyuanli@didiglobal$(echo .)com \
--cc=kerneljasonxing@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=ncardwell@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=tiozhang@didiglobal$(echo .)com \
--cc=toke@toke$(echo .)dk \
--cc=ycheng@google$(echo .)com \
--cc=zhangweiping@didiglobal$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox