Subject: Re: [PATCH next] drivers: wireless: carl9170: shrink carl9170_tx_info

From: Christian Lamparter <[email-masked]>
Date: Sat, 14 Mar 2015 12:51:57 +0100

On Friday, March 13, 2015 04:37:25 PM Florian Westphal wrote:
> its embededded inside rate_driver_data of the ieee80211_tx_info struct,
> which in turn is stored in skb->cb[].
> 
> In order to shrink cb, we need to shrink ieee80211_tx_info which means
> to downsize all users first.
> 
> Alternatively, one might be able to remove kref but
> its less intrusive/simpler to use u32 for timeout handling.
> 
> Signed-off-by: Florian Westphal <[email-masked]>
> ---
u32 jiffies... that's a lot of pointing (well not so much) and really 
ugly casting (a lot). I guess it would be easier to just use a "per-queue"
timeout watchdog like almost everybody else. This way, the driver will
be ready for the next skb->cb shrink as well.

carl9170_tx_ampdu_timeout can be completely removed.

Regards,
  Christian