From: patchwork-bot+netdevbpf@kernel•org
To: Russell King (Oracle) <linux@armlinux•org.uk>
Cc: andrew@lunn•ch, hkallweit1@gmail•com, chenhao418@huawei•com,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
shaojijie@huawei•com, lanhao@huawei•com, liuyonglong@huawei•com,
netdev@vger•kernel.org, pabeni@redhat•com, shenjian15@huawei•com,
wangjie125@huawei•com, wangpeiyang1@huawei•com
Subject: Re: [PATCH net-next 0/7] net: phy: avoid race when erroring stopping PHY
Date: Sun, 17 Sep 2023 13:40:24 +0000 [thread overview]
Message-ID: <169495802473.29369.10874261402549315982.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <ZQMn+Wkvod10vdLd@shell.armlinux.org.uk>
Hello:
This series was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft•net>:
On Thu, 14 Sep 2023 16:34:17 +0100 you wrote:
> This series addresses a problem reported by Jijie Shao where the PHY
> state machine can race with phy_stop() leading to an incorrect state.
>
> The issue centres around phy_state_machine() dropping the phydev->lock
> mutex briefly, which allows phy_stop() to get in half-way through the
> state machine, and when the state machine resumes, it overwrites
> phydev->state with a value incompatible with a stopped PHY. This causes
> a subsequent phy_start() to issue a warning.
>
> [...]
Here is the summary with links:
- [net-next,1/7] net: phy: always call phy_process_state_change() under lock
https://git.kernel.org/netdev/net-next/c/8da77df649c4
- [net-next,2/7] net: phy: call phy_error_precise() while holding the lock
https://git.kernel.org/netdev/net-next/c/ef113a60d0a9
- [net-next,3/7] net: phy: move call to start aneg
https://git.kernel.org/netdev/net-next/c/ea5968cd7d6e
- [net-next,4/7] net: phy: move phy_suspend() to end of phy_state_machine()
https://git.kernel.org/netdev/net-next/c/6e19b3502c59
- [net-next,5/7] net: phy: move phy_state_machine()
https://git.kernel.org/netdev/net-next/c/c398ef41b6d4
- [net-next,6/7] net: phy: split locked and unlocked section of phy_state_machine()
https://git.kernel.org/netdev/net-next/c/8635c0663e6b
- [net-next,7/7] net: phy: convert phy_stop() to use split state machine
https://git.kernel.org/netdev/net-next/c/adcbb85508c8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-09-17 13:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 15:34 [PATCH net-next 0/7] net: phy: avoid race when erroring stopping PHY Russell King (Oracle)
2023-09-14 15:35 ` [PATCH net-next 1/7] net: phy: always call phy_process_state_change() under lock Russell King (Oracle)
2023-09-14 18:21 ` Florian Fainelli
2023-09-18 12:33 ` Marek Szyprowski
2023-09-18 12:55 ` Andrew Lunn
2023-09-18 13:05 ` Marek Szyprowski
2023-09-18 13:07 ` Russell King (Oracle)
2023-09-18 13:06 ` Russell King (Oracle)
2023-09-18 13:15 ` Marek Szyprowski
2023-09-14 15:35 ` [PATCH net-next 2/7] net: phy: call phy_error_precise() while holding the lock Russell King (Oracle)
2023-09-14 18:21 ` Florian Fainelli
2023-09-14 15:35 ` [PATCH net-next 3/7] net: phy: move call to start aneg Russell King (Oracle)
2023-09-14 18:22 ` Florian Fainelli
2023-09-14 15:35 ` [PATCH net-next 4/7] net: phy: move phy_suspend() to end of phy_state_machine() Russell King (Oracle)
2023-09-14 18:22 ` Florian Fainelli
2023-09-14 15:35 ` [PATCH net-next 5/7] net: phy: move phy_state_machine() Russell King (Oracle)
2023-09-14 18:22 ` Florian Fainelli
2023-09-14 15:35 ` [PATCH net-next 6/7] net: phy: split locked and unlocked section of phy_state_machine() Russell King (Oracle)
2023-09-14 18:39 ` Florian Fainelli
2023-09-14 15:36 ` [PATCH net-next 7/7] net: phy: convert phy_stop() to use split state machine Russell King (Oracle)
2023-09-14 18:39 ` Florian Fainelli
2023-09-17 13:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169495802473.29369.10874261402549315982.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=chenhao418@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=lanhao@huawei$(echo .)com \
--cc=linux@armlinux$(echo .)org.uk \
--cc=liuyonglong@huawei$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=shaojijie@huawei$(echo .)com \
--cc=shenjian15@huawei$(echo .)com \
--cc=wangjie125@huawei$(echo .)com \
--cc=wangpeiyang1@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox