From: patchwork-bot+netdevbpf@kernel•org
To: Petr Machata <petrm@nvidia•com>
Cc: dsahern@gmail•com, stephen@networkplumber•org,
netdev@vger•kernel.org, phaddad@nvidia•com
Subject: Re: [PATCH iproute2-next v2 0/5] Change parsing in parse_one_of(), parse_on_off()
Date: Wed, 22 Nov 2023 19:40:26 +0000 [thread overview]
Message-ID: <170068202662.20203.769731586488523917.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <cover.1700666420.git.petrm@nvidia.com>
Hello:
This series was applied to iproute2/iproute2-next.git (main)
by David Ahern <dsahern@kernel•org>:
On Wed, 22 Nov 2023 16:23:27 +0100 you wrote:
> Library functions parse_one_of() and parse_on_off() were added about three
> years ago to unify all the disparate reimplementations of the same basic
> idea. It used the matches() function to determine whether a string under
> consideration corresponds to one of the keywords. This reflected many,
> though not all cases of on/off parsing at the time.
>
> This decision has some odd consequences. In particular, "o" can be used as
> a shorthand for "off", which is not obvious, because "o" is the prefix of
> both. By sheer luck, the end result actually makes some sense: "on" means
> on, anything else either means off or errors out. Similar issues are in
> principle also possible for parse_one_of() uses, though currently this does
> not come up.
>
> [...]
Here is the summary with links:
- [iproute2-next,v2,1/5] lib: utils: Switch matches() to returning int again
https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=60254925ccab
- [iproute2-next,v2,2/5] lib: utils: Generalize parse_one_of()
https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=256e0ca4b84f
- [iproute2-next,v2,3/5] lib: utils: Convert parse_on_off() to strcmp()
https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=5ba57152d27c
- [iproute2-next,v2,4/5] lib: utils: Introduce parse_one_of_deprecated()
https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=2b8766663d3c
- [iproute2-next,v2,5/5] lib: utils: Have parse_one_of() warn about prefix matches
https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=bd5226437a4c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-11-22 19:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 15:23 [PATCH iproute2-next v2 0/5] Change parsing in parse_one_of(), parse_on_off() Petr Machata
2023-11-22 15:23 ` [PATCH iproute2-next v2 1/5] lib: utils: Switch matches() to returning int again Petr Machata
2023-11-22 15:23 ` [PATCH iproute2-next v2 2/5] lib: utils: Generalize parse_one_of() Petr Machata
2023-11-22 15:23 ` [PATCH iproute2-next v2 3/5] lib: utils: Convert parse_on_off() to strcmp() Petr Machata
2023-11-22 15:23 ` [PATCH iproute2-next v2 4/5] lib: utils: Introduce parse_one_of_deprecated() Petr Machata
2023-11-22 15:23 ` [PATCH iproute2-next v2 5/5] lib: utils: Have parse_one_of() warn about prefix matches Petr Machata
2023-11-22 19:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170068202662.20203.769731586488523917.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=dsahern@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=petrm@nvidia$(echo .)com \
--cc=phaddad@nvidia$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox