From: patchwork-bot+netdevbpf@kernel•org
To: Pablo Neira Ayuso <pablo@netfilter•org>
Cc: netfilter-devel@vger•kernel.org, davem@davemloft•net,
netdev@vger•kernel.org, kuba@kernel•org, pabeni@redhat•com,
edumazet@google•com, fw@strlen•de
Subject: Re: [PATCH net 1/2] netfilter: nf_tables: set transport offset from mac header for netdev/egress
Date: Fri, 29 Dec 2023 08:00:25 +0000 [thread overview]
Message-ID: <170383682580.6676.16830645380063126929.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20231222104205.354606-2-pablo@netfilter.org>
Hello:
This series was applied to netdev/net.git (main)
by Pablo Neira Ayuso <pablo@netfilter•org>:
On Fri, 22 Dec 2023 11:42:04 +0100 you wrote:
> Before this patch, transport offset (pkt->thoff) provides an offset
> relative to the network header. This is fine for the inet families
> because skb->data points to the network header in such case. However,
> from netdev/egress, skb->data points to the mac header (if available),
> thus, pkt->thoff is missing the mac header length.
>
> Add skb_network_offset() to the transport offset (pkt->thoff) for
> netdev, so transport header mangling works as expected. Adjust payload
> fast eval function to use skb->data now that pkt->thoff provides an
> absolute offset. This explains why users report that matching on
> egress/netdev works but payload mangling does not.
>
> [...]
Here is the summary with links:
- [net,1/2] netfilter: nf_tables: set transport offset from mac header for netdev/egress
https://git.kernel.org/netdev/net/c/0ae8e4cca787
- [net,2/2] netfilter: nf_tables: skip set commit for deleted/destroyed sets
https://git.kernel.org/netdev/net/c/7315dc1e122c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2023-12-29 8:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 10:42 [PATCH net 0/2] Netfilter fixes for net Pablo Neira Ayuso
2023-12-22 10:42 ` [PATCH net 1/2] netfilter: nf_tables: set transport offset from mac header for netdev/egress Pablo Neira Ayuso
2023-12-29 8:00 ` patchwork-bot+netdevbpf [this message]
2023-12-22 10:42 ` [PATCH net 2/2] netfilter: nf_tables: skip set commit for deleted/destroyed sets Pablo Neira Ayuso
2023-12-22 10:49 ` [PATCH net 0/2] Netfilter fixes for net Pablo Neira Ayuso
2023-12-22 10:53 ` Pablo Neira Ayuso
-- strict thread matches above, loose matches on Subject: below --
2023-12-20 15:15 Pablo Neira Ayuso
2023-12-20 15:15 ` [PATCH net 1/2] netfilter: nf_tables: set transport offset from mac header for netdev/egress Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170383682580.6676.16830645380063126929.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pablo@netfilter$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox