From: patchwork-bot+netdevbpf@kernel•org
To: Alexander Lobakin <aleksander.lobakin@intel•com>
Cc: davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, dan.carpenter@linaro•org, dsahern@kernel•org,
horms@kernel•org, nex.sw.ncis.osdt.itp.upstreaming@intel•com,
netdev@vger•kernel.org, intel-wired-lan@lists•osuosl.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH net-next] ip_tunnel: harden copying IP tunnel params to userspace
Date: Mon, 08 Apr 2024 10:10:27 +0000 [thread overview]
Message-ID: <171257102713.30740.3149927029161291551.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240404160302.3585661-1-aleksander.lobakin@intel.com>
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft•net>:
On Thu, 4 Apr 2024 18:03:02 +0200 you wrote:
> Structures which are about to be copied to userspace shouldn't have
> uninitialized fields or paddings.
> memset() the whole &ip_tunnel_parm in ip_tunnel_parm_to_user() before
> filling it with the kernel data. The compilers will hopefully combine
> writes to it.
>
> Fixes: 117aef12a7b1 ("ip_tunnel: use a separate struct to store tunnel params in the kernel")
> Reported-by: Dan Carpenter <dan.carpenter@linaro•org>
> Closes: https://lore.kernel.org/netdev/5f63dd25-de94-4ca3-84e6-14095953db13@moroto.mountain
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel•com>
>
> [...]
Here is the summary with links:
- [net-next] ip_tunnel: harden copying IP tunnel params to userspace
https://git.kernel.org/netdev/net-next/c/5a66cda52d7d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-04-08 10:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 16:03 [PATCH net-next] ip_tunnel: harden copying IP tunnel params to userspace Alexander Lobakin
2024-04-08 7:48 ` Simon Horman
2024-04-08 10:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171257102713.30740.3149927029161291551.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=aleksander.lobakin@intel$(echo .)com \
--cc=dan.carpenter@linaro$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nex.sw.ncis.osdt.itp.upstreaming@intel$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox