From: patchwork-bot+netdevbpf@kernel•org
To: Simon Horman <horms@kernel•org>
Cc: davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, jmaloy@redhat•com, ying.xue@windriver•com,
per.liden@nospam•ericsson.com, netdev@vger•kernel.org,
tipc-discussion@lists•sourceforge.net
Subject: Re: [PATCH net-next v2] tipc: guard against string buffer overrun
Date: Sat, 03 Aug 2024 00:30:34 +0000 [thread overview]
Message-ID: <172264503415.23714.14575733017599531449.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240801-tipic-overrun-v2-1-c5b869d1f074@kernel.org>
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel•org>:
On Thu, 01 Aug 2024 19:35:37 +0100 you wrote:
> Smatch reports that copying media_name and if_name to name_parts may
> overwrite the destination.
>
> .../bearer.c:166 bearer_name_validate() error: strcpy() 'media_name' too large for 'name_parts->media_name' (32 vs 16)
> .../bearer.c:167 bearer_name_validate() error: strcpy() 'if_name' too large for 'name_parts->if_name' (1010102 vs 16)
>
> This does seem to be the case so guard against this possibility by using
> strscpy() and failing if truncation occurs.
>
> [...]
Here is the summary with links:
- [net-next,v2] tipc: guard against string buffer overrun
https://git.kernel.org/netdev/net-next/c/6555a2a9212b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-08-03 0:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 18:35 [PATCH net-next v2] tipc: guard against string buffer overrun Simon Horman
2024-08-02 9:42 ` Simon Horman
2024-08-03 0:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172264503415.23714.14575733017599531449.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jmaloy@redhat$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=per.liden@nospam$(echo .)ericsson.com \
--cc=tipc-discussion@lists$(echo .)sourceforge.net \
--cc=ying.xue@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox