From: patchwork-bot+netdevbpf@kernel•org
To: Stephen Hemminger <stephen@networkplumber•org>
Cc: netdev@vger•kernel.org, markovicbudimir@gmail•com,
jhs@mojatatu•com, xiyou.wangcong@gmail•com, jiri@resnulli•us,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, lansheng@huawei•com,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH] netem: fix return value if duplicate enqueue fails
Date: Wed, 21 Aug 2024 00:40:31 +0000 [thread overview]
Message-ID: <172420083178.1283142.17547445579493801272.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240819175753.5151-1-stephen@networkplumber.org>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel•org>:
On Mon, 19 Aug 2024 10:56:45 -0700 you wrote:
> There is a bug in netem_enqueue() introduced by
> commit 5845f706388a ("net: netem: fix skb length BUG_ON in __skb_to_sgvec")
> that can lead to a use-after-free.
>
> This commit made netem_enqueue() always return NET_XMIT_SUCCESS
> when a packet is duplicated, which can cause the parent qdisc's q.qlen to be
> mistakenly incremented. When this happens qlen_notify() may be skipped on the
> parent during destruction, leaving a dangling pointer for some classful qdiscs
> like DRR.
>
> [...]
Here is the summary with links:
- netem: fix return value if duplicate enqueue fails
https://git.kernel.org/netdev/net/c/c07ff8592d57
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-08-21 0:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 17:56 [PATCH] netem: fix return value if duplicate enqueue fails Stephen Hemminger
2024-08-20 15:42 ` Simon Horman
2024-08-20 20:22 ` Stephen Hemminger
2024-08-21 0:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172420083178.1283142.17547445579493801272.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=lansheng@huawei$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=markovicbudimir@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox