From: patchwork-bot+netdevbpf@kernel•org
To: Furong Xu <0x1207@gmail•com>
Cc: boon.leong.ong@intel•com, davem@davemloft•net,
alexandre.torgue@foss•st.com, joabreu@synopsys•com,
edumazet@google•com, kuba@kernel•org, pabeni@redhat•com,
mcoquelin.stm32@gmail•com, jpinto@synopsys•com,
netdev@vger•kernel.org, linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, rmk+kernel@armlinux•org.uk,
linux@armlinux•org.uk, xfr@outlook•com
Subject: Re: [PATCH net v2] net: stmmac: set PP_FLAG_DMA_SYNC_DEV only if XDP is enabled
Date: Thu, 26 Sep 2024 08:50:31 +0000 [thread overview]
Message-ID: <172734063104.1173335.1175532614664829516.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240919121028.1348023-1-0x1207@gmail.com>
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat•com>:
On Thu, 19 Sep 2024 20:10:28 +0800 you wrote:
> Commit 5fabb01207a2 ("net: stmmac: Add initial XDP support") sets
> PP_FLAG_DMA_SYNC_DEV flag for page_pool unconditionally,
> page_pool_recycle_direct() will call page_pool_dma_sync_for_device()
> on every page even the page is not going to be reused by XDP program.
>
> When XDP is not enabled, the page which holds the received buffer
> will be recycled once the buffer is copied into new SKB by
> skb_copy_to_linear_data(), then the MAC core will never reuse this
> page any longer. Always setting PP_FLAG_DMA_SYNC_DEV wastes CPU cycles
> on unnecessary calling of page_pool_dma_sync_for_device().
>
> [...]
Here is the summary with links:
- [net,v2] net: stmmac: set PP_FLAG_DMA_SYNC_DEV only if XDP is enabled
https://git.kernel.org/netdev/net/c/b514c47ebf41
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2024-09-26 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 12:10 [PATCH net v2] net: stmmac: set PP_FLAG_DMA_SYNC_DEV only if XDP is enabled Furong Xu
2024-09-26 8:50 ` patchwork-bot+netdevbpf [this message]
2024-10-01 10:22 ` Jon Hunter
2024-10-04 14:08 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172734063104.1173335.1175532614664829516.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=0x1207@gmail$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=boon.leong.ong@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=jpinto@synopsys$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=rmk+kernel@armlinux$(echo .)org.uk \
--cc=xfr@outlook$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox