From: Nagendra Tomar <tomer_iisc@yahoo•com>
To: Eric Dumazet <eric.dumazet@gmail•com>,
Evgeniy Polyakov <zbr@ioremap•net>
Cc: netdev@vger•kernel.org, davem@davemloft•net
Subject: Re: [PATCH] net: Fix __inet_inherit_port() to correctly increment bsockets and num_owners
Date: Fri, 26 Nov 2010 03:20:31 -0800 (PST) [thread overview]
Message-ID: <174335.2288.qm@web53702.mail.re2.yahoo.com> (raw)
In-Reply-To: <20101126110726.GA5648@ioremap.net>
--- On Fri, 26/11/10, Evgeniy Polyakov <zbr@ioremap•net> wrote:
> Frankly I did not find how those optimizations made a bug
> as well as
> what is this bug about from given description, but I'm glad
> it is resolved now :)
>
I'm not sure of what all went into the "optimization" patch, but the bug is not due to the optimization per-se. As my original post says, it is due to the 'bsockets' and 'num_owners' not being incremented inside __inet_inherit_port(), where it should have been, as __inet_put_port() decrements them on port release, which causes the imbalance.
Thanks,
Tomar
next prev parent reply other threads:[~2010-11-26 11:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 5:09 [PATCH] net: Fix __inet_inherit_port() to correctly increment bsockets and num_owners Nagendra Tomar
2010-11-26 7:20 ` Eric Dumazet
2010-11-26 7:49 ` Nagendra Tomar
2010-11-26 8:23 ` Eric Dumazet
2010-11-26 9:40 ` Nagendra Tomar
2010-11-26 10:47 ` Eric Dumazet
2010-11-26 11:01 ` Nagendra Tomar
2010-11-26 11:07 ` Evgeniy Polyakov
2010-11-26 11:20 ` Nagendra Tomar [this message]
2010-11-26 15:56 ` Evgeniy Polyakov
2010-11-27 0:01 ` [PATCH] net-next: " Nagendra Tomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174335.2288.qm@web53702.mail.re2.yahoo.com \
--to=tomer_iisc@yahoo$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=zbr@ioremap$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox