Subject: Re: [PATCH v3 12/24] wfx: add hif_api_*.h

From: Jérôme Pouiller <[email-masked]>
Date: Tue, 22 Dec 2020 22:05:14 +0100

On Tuesday 22 December 2020 16:20:46 CET Kalle Valo wrote:
> Jerome Pouiller <[email-masked]> writes:
> 
> > --- /dev/null
> > +++ b/drivers/net/wireless/silabs/wfx/hif_api_general.h
> > @@ -0,0 +1,267 @@
> > +/* SPDX-License-Identifier: Apache-2.0 */
> > +/*
> > + * WFx hardware interface definitions
> > + *
> > + * Copyright (c) 2018-2020, Silicon Laboratories Inc.
> > + */
> > +
> > +#ifndef WFX_HIF_API_GENERAL_H
> > +#define WFX_HIF_API_GENERAL_H
> > +
> > +#ifdef __KERNEL__
> > +#include <linux/types.h>
> > +#include <linux/if_ether.h>
> > +#else
> > +#include <net/ethernet.h>
> > +#include <stdint.h>
> > +#define __packed __attribute__((__packed__))
> > +#endif
> 
> Why check for __KERNEL__ and redefined __packed? These don't belong to a
> wireless driver.

In the old days, this file was shared with other projects. I though I had
cleaned all these things.

-- 
Jérôme Pouiller