From: Jason Wang <jasowang@redhat•com>
To: Eli Cohen <elic@nvidia•com>
Cc: "Michael S. Tsirkin" <mst@redhat•com>, Cindy Lu <lulu@redhat•com>,
virtualization@lists•linux-foundation.org,
netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH] vdpa/mlx5: Setup driver only if VIRTIO_CONFIG_S_DRIVER_OK
Date: Tue, 8 Sep 2020 22:06:50 -0400 (EDT) [thread overview]
Message-ID: <1815785246.16284907.1599617210463.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20200907110335.GA121033@mtl-vdi-166.wap.labs.mlnx>
----- Original Message -----
> On Mon, Sep 07, 2020 at 06:53:23AM -0400, Jason Wang wrote:
> >
> >
> > ----- Original Message -----
> > > If the memory map changes before the driver status is
> > > VIRTIO_CONFIG_S_DRIVER_OK, don't attempt to create resources because it
> > > may fail. For example, if the VQ is not ready there is no point in
> > > creating resources.
> > >
> > > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5
> > > devices")
> > > Signed-off-by: Eli Cohen <elic@nvidia•com>
> > > ---
> > > drivers/vdpa/mlx5/net/mlx5_vnet.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > index 9df69d5efe8c..c89cd48a0aab 100644
> > > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > @@ -1645,6 +1645,9 @@ static int mlx5_vdpa_change_map(struct
> > > mlx5_vdpa_net
> > > *ndev, struct vhost_iotlb *
> > > if (err)
> > > goto err_mr;
> > >
> > > + if (!(ndev->mvdev.status & VIRTIO_CONFIG_S_DRIVER_OK))
> > > + return 0;
> > > +
> >
> > I'm not sure I get this.
> >
> > It looks to me if set_map() is called before DRIVER_OK, we won't build
> > any mapping?
> >
> What would prevent that? Is it some qemu logic you're relying upon?
Ok, I think the map is still there, we just avoid to create some
resources.
> With current qemu 5.1 with lack of batching support, I get plenty calls
> to set_map which result in calls to mlx5_vdpa_change_map().
> If that happens before VIRTIO_CONFIG_S_DRIVER_OK then Imay fail (in case
> I was not called to set VQs ready).
Right, this could be solved by adding the batched IOTLB updating.
Thanks
>
> >
> > > restore_channels_info(ndev);
> > > err = setup_driver(ndev);
> > > if (err)
> > > --
> > > 2.26.0
> > >
> > >
> >
>
>
next prev parent reply other threads:[~2020-09-09 2:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 7:51 [PATCH] vdpa/mlx5: Setup driver only if VIRTIO_CONFIG_S_DRIVER_OK Eli Cohen
2020-09-07 10:53 ` Jason Wang
2020-09-07 11:03 ` Eli Cohen
2020-09-09 2:06 ` Jason Wang [this message]
2020-09-07 11:34 ` Michael S. Tsirkin
2020-09-07 11:43 ` Eli Cohen
2020-09-08 12:04 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1815785246.16284907.1599617210463.JavaMail.zimbra@redhat.com \
--to=jasowang@redhat$(echo .)com \
--cc=elic@nvidia$(echo .)com \
--cc=lulu@redhat$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox