From: Andreas Schultz <aschultz@tpip•net>
To: Jiannan Ouyang <ouyangj@fb•com>
Cc: osmocom-net-gprs <osmocom-net-gprs@lists•osmocom.org>,
netdev <netdev@vger•kernel.org>,
dev@openvswitch•org, pablo <pablo@netfilter•org>,
laforge <laforge@gnumonks•org>,
pshelar@nicira•com,
wieger ijntema tno <wieger.ijntema.tno@gmail•com>,
yi y yang <yi.y.yang@intel•com>,
joe@ovn•org, Amar Padmanabhan <amarpadmanabhan@fb•com>
Subject: Re: [PATCH net-next v1 1/3] gtp: refactor to support flow-based gtp encap and decap
Date: Mon, 31 Jul 2017 09:21:36 +0200 (CEST) [thread overview]
Message-ID: <1825145503.799984.1501485696720.JavaMail.zimbra@tpip.net> (raw)
In-Reply-To: <20170713004455.3946570-2-ouyangj@fb.com>
Hi Jiannan,
----- On Jul 13, 2017, at 2:44 AM, Jiannan Ouyang ouyangj@fb•com wrote:
[...]
> -static int gtp_rx(struct pdp_ctx *pctx, struct sk_buff *skb,
> - unsigned int hdrlen, unsigned int role)
> +static int gtp_rx(struct gtp_dev *gtp, struct sk_buff *skb,
> + unsigned int hdrlen, struct sock *sk,
> + struct metadata_dst *tun_dst)
Some time ago, there was an extensive discussion about the relation
of PDP context and network devices. You are basically reverting one
of the changes that was made in that context. I think it is wrong to
couple GTP devices and PDP context the way you do here (there are
people that disagree, though).
The GTP network device of one of two structures owning the PDP context,
the other is the GTP socket. GTP network devices and GTP sockets should
be strictly separated.
The GTP network device owns the IP given to the MS, handles mapping
IP's into GTP tunnels (peer GSN + TEIDs) and hands the resulting GTP
packets of to the GTP socket for sending. The GTP socket decaps the GTP
packet, find the right context and based on information therein passes
it to the GTP network device.
By separating is that way, you can have MS with overlapping or colliding
IP's on the same GTP socket as long as they belong to different GTP network
devices.
We had a length discussion about whether the above scenario makes sense.
I'm not sure if we reached a final verdict, but the 3GPP specifications
clearly permit such a setup.
Regards
Andreas
next prev parent reply other threads:[~2017-07-31 7:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 0:44 [PATCH net-next v1 0/3] Flow Based GTP Tunneling Jiannan Ouyang
[not found] ` <20170713004455.3946570-1-ouyangj-b10kYP2dOMg@public.gmane.org>
2017-07-13 0:44 ` [PATCH net-next v1 1/3] gtp: refactor to support flow-based gtp encap and decap Jiannan Ouyang
2017-07-13 7:26 ` Harald Welte
2017-07-14 0:55 ` Jiannan Ouyang
[not found] ` <3729E0DA-08AB-4C5C-B9EC-C76DAAA60E10-b10kYP2dOMg@public.gmane.org>
2017-07-14 8:03 ` Harald Welte
2017-07-31 7:21 ` Andreas Schultz [this message]
2017-08-02 12:52 ` Pablo Neira Ayuso
2017-07-13 0:44 ` [PATCH net-next v1 2/3] gtp: Support creating flow-based gtp net_device Jiannan Ouyang
[not found] ` <20170713004455.3946570-3-ouyangj-b10kYP2dOMg@public.gmane.org>
2017-07-13 7:35 ` Harald Welte
2017-07-14 1:01 ` Jiannan Ouyang
2017-07-14 8:12 ` Harald Welte
2017-07-13 18:01 ` Joe Stringer
2017-07-13 1:28 ` [PATCH net-next v1 0/3] Flow Based GTP Tunneling Joe Stringer
2017-07-13 0:44 ` [PATCH net-next v1 3/3] openvswitch: Add GPRS Tunnel Protocol (GTP) vport support Jiannan Ouyang
2017-07-13 7:12 ` [PATCH net-next v1 0/3] Flow Based GTP Tunneling Harald Welte
2017-07-13 18:14 ` Joe Stringer
2017-07-13 22:54 ` Jiannan Ouyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1825145503.799984.1501485696720.JavaMail.zimbra@tpip.net \
--to=aschultz@tpip$(echo .)net \
--cc=amarpadmanabhan@fb$(echo .)com \
--cc=dev@openvswitch$(echo .)org \
--cc=joe@ovn$(echo .)org \
--cc=laforge@gnumonks$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=osmocom-net-gprs@lists$(echo .)osmocom.org \
--cc=ouyangj@fb$(echo .)com \
--cc=pablo@netfilter$(echo .)org \
--cc=pshelar@nicira$(echo .)com \
--cc=wieger.ijntema.tno@gmail$(echo .)com \
--cc=yi.y.yang@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox